Commit graph

1089 commits

Author SHA1 Message Date
Azaezel 1df7e47a89 From @LuisAntonRebollo -Stymies infinite loop on exit with SDL2+opengl on windows. 2015-08-13 15:34:41 -05:00
Azaezel 7df625ea14 Adds data to vector out of bounds reports
Like say, if it's crashing out due to being passed a -1, or adding past the end.
2015-08-12 16:17:08 -05:00
Areloch 9782490894 Merge pull request #1388 from Areloch/SDL_Scroll_Speed_Fix
SDL mouse wheel speed fix.
2015-08-10 08:44:15 -05:00
Daniel Buckmaster c0e82d72a2 Merge pull request #1391 from Azaezel/C4706
warning C4706: assignment within conditional expression
2015-08-08 14:04:35 +10:00
Areloch 5efc04dd47 Also apply scroll strength to horizontal scrolling. 2015-08-06 22:18:10 -05:00
Azaezel c100d7f932 suggested revision 2015-08-06 21:56:46 -05:00
Azaezel 5bc926e97c warning C4005: 'WIN32' : macro redefinition 2015-08-06 21:01:20 -05:00
Azaezel af38320300 warning C4706: assignment within conditional expression 2015-08-06 20:52:48 -05:00
Areloch 68a2c9fa89 Added a default value just in case the pref is not defined. 2015-08-06 18:29:01 -05:00
Areloch 8248ecdeac Looks like WHEEL_DELTA is defined for win and osx, but not linux. Retooling to utilize a $pref instead, as that will let the scroll speed be modifiable for any projects that need it. 2015-08-05 17:44:55 -05:00
Areloch 3aba4a7259 SDL mouse wheel speed fix.
Default scroll speed wasn't delta-modified, so scroll gui controls were very slow when scrolled via mouse wheel.. This corrects the issue.
2015-08-04 23:01:59 -05:00
Areloch b614d87e78 Fixes the menubar functionality when using SDL.
This resolves menu order, cleanup and close/re-open issues, as well as crashes on close.

It also modifies the look slightly to look closer to the windows menubar to keep a cohesive look regardless of platform.
2015-08-04 22:57:25 -05:00
Areloch 63ae781d24 Merge pull request #1376 from Azaezel/TreeViewTerror
From Dušan Jocić: early out of treeview entries to prevent crashes
2015-07-30 10:56:41 -05:00
Areloch 2695a2aeae Merge pull request #1383 from Azaezel/MangledMouse
sdl2 mouse wheel scrolling
2015-07-30 09:24:38 -05:00
Azaezel 4a8f6737b6 Mouse wheel check has to occur before mouse motion. Apparently the one is a subset of the other. also thanks @dottools for the proper codeline. 2015-07-29 20:36:33 -05:00
Azaezel 98d48b6011 Fatality Fix: need to account for 64 bit windows as well. 2015-07-29 11:50:47 -05:00
Azaezel 06f6819d63 sdl2 mouse wheel scrolling rev1 2015-07-29 11:24:48 -05:00
Azaezel 2238dd66da From Dušan Jocić: early out of treeview entries to prevent crashes
"when you change some item or remove, it does not resize the array and in that way it create problem with value"
2015-07-28 18:35:11 -05:00
Daniel Buckmaster 4721181d44 Merge pull request #1361 from Azaezel/BulletBreak1
adds minimum displacement check prior to convexSweepTest to avoid NaNs
2015-07-27 12:20:33 +10:00
Daniel Buckmaster 0ed74bc8f5 Merge pull request #1362 from Azaezel/BulletBreak2
Removes fatal assertion on duplicated object collisions (meshroads, primarily)
2015-07-26 09:41:10 +10:00
Daniel Buckmaster 807aad826f Merge pull request #1357 from Azaezel/ChaseCache
followobject position caching
2015-07-25 15:22:14 +10:00
Daniel Buckmaster e65afa95a9 Merge pull request #1354 from Areloch/PVS_Cleanup_mEase
Cleanup of ease functions operations.
2015-07-25 13:48:46 +10:00
Daniel Buckmaster d91ec87d3e Merge pull request #1371 from eightyeight/vs2015-warnings-1
Random VS warnings
2015-07-25 10:55:45 +10:00
Areloch adc9c9e8a4 Merge pull request #1370 from eightyeight/fix-precipitation-hiding
Stop precipitation from processing ticks when it's hidden
2015-07-23 09:48:02 -05:00
Daniel Buckmaster d268199f4f Merge pull request #1339 from Areloch/Remove_Demo_Mode_Checks
Remove demo and trial checks
2015-07-23 20:33:31 +10:00
Daniel Buckmaster e10b421641 C4458 declaration hides class member.
There are plenty more of these, but they should be fixed by revising the
names of members to start with m, instead of fixing the local violations.
There was a previous PR for that but it went badly. Will retry again one
day.
2015-07-23 20:13:04 +10:00
Daniel Buckmaster 5e2de608d5 C4091 typedef ignored. 2015-07-23 20:03:30 +10:00
Daniel Buckmaster 9217dfa4bd Stop precipitation from processing ticks when it's hidden. 2015-07-23 19:34:46 +10:00
Daniel Buckmaster 33037a2f45 Merge pull request #1173 from JeffProgrammer/gestalt_fix_gg
remove gestalt() as it has been deprecated and stopped working on Mac OS...
2015-07-23 16:20:36 +10:00
Daniel Buckmaster b940c9eada Merge pull request #1365 from Areloch/PVS_Cleanup_668
Removing pointless null-pointer tests for objects created with new
2015-07-23 12:03:18 +10:00
Areloch 6a418d4d7f Merge pull request #1037 from Lopuska/patch-9
Black screen fix
2015-07-22 11:54:35 -05:00
Areloch 527c3790d6 Issue found with PVS-Studio:
Many instances where we would create a object via a new call, and then check that it was non-null.

This is redundant, as if we ever were in a situation where new failed, we'd be crashing left and right already, so the additional check is wasted processing.
2015-07-21 23:22:21 -05:00
Daniel Buckmaster db532c0e1a Merge pull request #1358 from Azaezel/tinyTurretTransmission
reduces rotation transmission size
2015-07-20 23:04:51 +10:00
Daniel Buckmaster 4f2f1ca4e1 Merge pull request #1356 from Areloch/PVS_Cleanup_813
Convert un-modified function arguments to const references.
2015-07-20 22:55:22 +10:00
Areloch 73c6db715d Corrected spacing on the brackets to line them back up 2015-07-19 02:02:07 -05:00
Azaezel 070d7db9a9 allowplayerstep lets folks run up sharper angles than normal. that should be off by default. 2015-07-17 14:33:02 -05:00
Azaezel edce2cc566 adds minimum displacement check prior to convexSweepTest to avoid NaNs 2015-07-17 14:28:30 -05:00
Azaezel e9a1d2158b BulletCrashfix2
Removes fatal assertion on duplicated object collisions (meshroads, primarily)
2015-07-17 14:25:01 -05:00
Azaezel 656efbfeb7 lastpos init. world-center. 2015-07-17 14:04:02 -05:00
Azaezel f97dced4a7 followobject position caching
re-use the position of an object we're following (within reason) so we're not constantly regenning a path.
2015-07-17 03:34:22 -05:00
Daniel Buckmaster c2e5dc3345 Merge remote-tracking branch 'bpay/clang-cl-build-fixes' into development
Conflicts:
	Engine/source/T3D/shapeBase.h
2015-07-17 16:55:12 +10:00
Azaezel 55c0f1ec29 reduces rotation transmission size from 64 bits per turret to 14 similar to player 2015-07-17 00:12:10 -05:00
Areloch 11398bb04e Issue found with PVS-Studio:
A lot of instances where some function args are not actually modified in any way, meaning that it is better for performance to convert them into const references. This prevents an additional copy, which can help performance.
2015-07-16 22:02:18 -05:00
Daniel Buckmaster 86e0e67496 Merge pull request #1352 from Areloch/PVS_Cleanup_807
Unnecessarily repeated expressions
2015-07-16 15:45:32 +10:00
Areloch 2f94ab0637 Issue found with PVS-Studio:
Many instances of a variable being modified inside of a complex operation. This could lead to unintended results depending on the whims of the compiler.

Resolved by restructuring the functions to modify the variable first, then do the rest of the operation.
2015-07-13 23:45:55 -05:00
Areloch 5c688260d5 Issue found with PVS-Studio:
Many places utilize post-incrementation with iterators, but it's better performance to use pre-incrementation.

Resolved by changing the iter++ instances to ++iter;
2015-07-13 23:08:17 -05:00
Areloch 2002d74b78 Issue found with PVS-Studio:
Many instances of a function or expression being used repeatedly, which can lower performance.

Fixed it in these cases by creating on local var, reference or pointer that's used instead.
2015-07-13 22:51:17 -05:00
Daniel Buckmaster ec63398042 Merge pull request #1350 from Azaezel/timingIsEverything
fills in profiler timer fallback
2015-07-13 11:03:26 +10:00
Daniel Buckmaster 50183c6a2a Merge pull request #901 from Winterleaf/winMath_ASM.cpp
FFP 64bit
2015-07-12 16:18:22 +10:00
Daniel Buckmaster bac84eec3c Merge pull request #992 from Winterleaf/Fix-engineFunctions.h
Pragma pack for x32/x64
2015-07-12 16:17:45 +10:00