Commit graph

3993 commits

Author SHA1 Message Date
Areloch
a5b48225c7 Corrected the terrain issue caused by unwanted early-outing due to prior changes. 2015-07-29 10:14:19 -05:00
Azaezel
5615b642df suggested revision 2015-07-29 08:41:36 -05:00
Azaezel
3c1c88d96b TORQUE_VALIDATE_STACK define for console stack debugging 2015-07-29 04:46:36 -05:00
Azaezel
555610f69f Addresses roughly half of the C4189 errors though the following methodologies:
1) truly unused vars removed
2) vars leading to remmed out code for debugging remmed in turn.

left out:
vars in macros.
2015-07-29 03:03:27 -05:00
Azaezel
005c3c4b36 From Dušan Jocić: additional debugdraw entries. DirectionLine, OutlinedText, Capsule 2015-07-29 01:41:09 -05:00
Areloch
3a18819e1e Issue found by PVS Studio:
Several instances where we utilize a pointer variable without properly testing that they aren't null first.
2015-07-28 23:25:09 -05:00
Azaezel
2238dd66da From Dušan Jocić: early out of treeview entries to prevent crashes
"when you change some item or remove, it does not resize the array and in that way it create problem with value"
2015-07-28 18:35:11 -05:00
Areloch
859e653bd7 Redux of Winterleaf's PR 1001, with the suggested updated values. 2015-07-28 00:53:58 -05:00
Daniel Buckmaster
4721181d44 Merge pull request #1361 from Azaezel/BulletBreak1
adds minimum displacement check prior to convexSweepTest to avoid NaNs
2015-07-27 12:20:33 +10:00
Daniel Buckmaster
0ed74bc8f5 Merge pull request #1362 from Azaezel/BulletBreak2
Removes fatal assertion on duplicated object collisions (meshroads, primarily)
2015-07-26 09:41:10 +10:00
Daniel Buckmaster
807aad826f Merge pull request #1357 from Azaezel/ChaseCache
followobject position caching
2015-07-25 15:22:14 +10:00
Daniel Buckmaster
e65afa95a9 Merge pull request #1354 from Areloch/PVS_Cleanup_mEase
Cleanup of ease functions operations.
2015-07-25 13:48:46 +10:00
Daniel Buckmaster
d91ec87d3e Merge pull request #1371 from eightyeight/vs2015-warnings-1
Random VS warnings
2015-07-25 10:55:45 +10:00
Areloch
adc9c9e8a4 Merge pull request #1370 from eightyeight/fix-precipitation-hiding
Stop precipitation from processing ticks when it's hidden
2015-07-23 09:48:02 -05:00
Daniel Buckmaster
d268199f4f Merge pull request #1339 from Areloch/Remove_Demo_Mode_Checks
Remove demo and trial checks
2015-07-23 20:33:31 +10:00
Daniel Buckmaster
e10b421641 C4458 declaration hides class member.
There are plenty more of these, but they should be fixed by revising the
names of members to start with m, instead of fixing the local violations.
There was a previous PR for that but it went badly. Will retry again one
day.
2015-07-23 20:13:04 +10:00
Daniel Buckmaster
5e2de608d5 C4091 typedef ignored. 2015-07-23 20:03:30 +10:00
Daniel Buckmaster
9217dfa4bd Stop precipitation from processing ticks when it's hidden. 2015-07-23 19:34:46 +10:00
Daniel Buckmaster
33037a2f45 Merge pull request #1173 from JeffProgrammer/gestalt_fix_gg
remove gestalt() as it has been deprecated and stopped working on Mac OS...
2015-07-23 16:20:36 +10:00
Daniel Buckmaster
b940c9eada Merge pull request #1365 from Areloch/PVS_Cleanup_668
Removing pointless null-pointer tests for objects created with new
2015-07-23 12:03:18 +10:00
Areloch
6a418d4d7f Merge pull request #1037 from Lopuska/patch-9
Black screen fix
2015-07-22 11:54:35 -05:00
Areloch
527c3790d6 Issue found with PVS-Studio:
Many instances where we would create a object via a new call, and then check that it was non-null.

This is redundant, as if we ever were in a situation where new failed, we'd be crashing left and right already, so the additional check is wasted processing.
2015-07-21 23:22:21 -05:00
Daniel Buckmaster
db532c0e1a Merge pull request #1358 from Azaezel/tinyTurretTransmission
reduces rotation transmission size
2015-07-20 23:04:51 +10:00
Daniel Buckmaster
4f2f1ca4e1 Merge pull request #1356 from Areloch/PVS_Cleanup_813
Convert un-modified function arguments to const references.
2015-07-20 22:55:22 +10:00
Areloch
73c6db715d Corrected spacing on the brackets to line them back up 2015-07-19 02:02:07 -05:00
MusicMonkey5555
a22672dd7a Update guiConsoleTextCtrl.cpp
Removed redundant assignment.
2015-07-17 16:40:39 -07:00
Azaezel
070d7db9a9 allowplayerstep lets folks run up sharper angles than normal. that should be off by default. 2015-07-17 14:33:02 -05:00
Azaezel
edce2cc566 adds minimum displacement check prior to convexSweepTest to avoid NaNs 2015-07-17 14:28:30 -05:00
Azaezel
e9a1d2158b BulletCrashfix2
Removes fatal assertion on duplicated object collisions (meshroads, primarily)
2015-07-17 14:25:01 -05:00
Azaezel
656efbfeb7 lastpos init. world-center. 2015-07-17 14:04:02 -05:00
Azaezel
f97dced4a7 followobject position caching
re-use the position of an object we're following (within reason) so we're not constantly regenning a path.
2015-07-17 03:34:22 -05:00
Daniel Buckmaster
c2e5dc3345 Merge remote-tracking branch 'bpay/clang-cl-build-fixes' into development
Conflicts:
	Engine/source/T3D/shapeBase.h
2015-07-17 16:55:12 +10:00
Azaezel
55c0f1ec29 reduces rotation transmission size from 64 bits per turret to 14 similar to player 2015-07-17 00:12:10 -05:00
Areloch
11398bb04e Issue found with PVS-Studio:
A lot of instances where some function args are not actually modified in any way, meaning that it is better for performance to convert them into const references. This prevents an additional copy, which can help performance.
2015-07-16 22:02:18 -05:00
Azaezel
4bba5d87d0 partly addresses https://msdn.microsoft.com/en-us/library/y775w13y.aspx?f=255&MSPPError=-2147217396 violations 2015-07-16 21:51:37 -05:00
Daniel Buckmaster
86e0e67496 Merge pull request #1352 from Areloch/PVS_Cleanup_807
Unnecessarily repeated expressions
2015-07-16 15:45:32 +10:00
Areloch
2f94ab0637 Issue found with PVS-Studio:
Many instances of a variable being modified inside of a complex operation. This could lead to unintended results depending on the whims of the compiler.

Resolved by restructuring the functions to modify the variable first, then do the rest of the operation.
2015-07-13 23:45:55 -05:00
Areloch
5c688260d5 Issue found with PVS-Studio:
Many places utilize post-incrementation with iterators, but it's better performance to use pre-incrementation.

Resolved by changing the iter++ instances to ++iter;
2015-07-13 23:08:17 -05:00
Areloch
2002d74b78 Issue found with PVS-Studio:
Many instances of a function or expression being used repeatedly, which can lower performance.

Fixed it in these cases by creating on local var, reference or pointer that's used instead.
2015-07-13 22:51:17 -05:00
Daniel Buckmaster
ec63398042 Merge pull request #1350 from Azaezel/timingIsEverything
fills in profiler timer fallback
2015-07-13 11:03:26 +10:00
Daniel Buckmaster
50183c6a2a Merge pull request #901 from Winterleaf/winMath_ASM.cpp
FFP 64bit
2015-07-12 16:18:22 +10:00
Daniel Buckmaster
bac84eec3c Merge pull request #992 from Winterleaf/Fix-engineFunctions.h
Pragma pack for x32/x64
2015-07-12 16:17:45 +10:00
Daniel Buckmaster
a49c9abf41 Merge pull request #1258 from bpay/fix-bad-assert
Remove badly behaved assert
2015-07-12 16:11:48 +10:00
Daniel Buckmaster
6cbb4d5b16 Merge pull request #1344 from eightyeight/fix-wreorder
Fix -Wreorder warnings from ShapeBase
2015-07-12 15:59:31 +10:00
Azaezel
bf1449e3a7 fills in profiler timer fallback as per remmed out lines in other samples. see https://github.com/GarageGames/Torque3D/issues/1349 for report, and https://gist.github.com/Azaezel/2aafb88cf0d642418051 for result 2015-07-10 19:33:42 -05:00
Daniel Buckmaster
e75a9fa081 Don't assert; sometimes there aren't any jobs to wait for! 2015-07-05 14:11:24 +10:00
Daniel Buckmaster
b491d7bbc0 Fix ThreadPool tests to account for asynchronicity. 2015-07-05 13:07:37 +10:00
Daniel Buckmaster
0995520d6f Add a method to wait for all pending items in a ThreadPool. 2015-07-05 12:59:52 +10:00
Daniel Buckmaster
7b2cb8d04f Add a method to see whether a WorkItem has executed yet. 2015-07-05 12:40:50 +10:00
Daniel Buckmaster
5caf62b19f Merge pull request #1342 from Azaezel/Offsetof
offsetof is actually a standard thing nowadays it would seem
2015-07-05 11:26:53 +10:00