Areloch
b54f41e36d
Merge pull request #1378 from Areloch/PVS_Cleanup_595
...
Properly testing pointer vars aren't null before using them.
2015-08-22 23:17:43 -05:00
Areloch
b614d87e78
Fixes the menubar functionality when using SDL.
...
This resolves menu order, cleanup and close/re-open issues, as well as crashes on close.
It also modifies the look slightly to look closer to the windows menubar to keep a cohesive look regardless of platform.
2015-08-04 22:57:25 -05:00
Areloch
3a18819e1e
Issue found by PVS Studio:
...
Several instances where we utilize a pointer variable without properly testing that they aren't null first.
2015-07-28 23:25:09 -05:00
Azaezel
2238dd66da
From Dušan Jocić: early out of treeview entries to prevent crashes
...
"when you change some item or remove, it does not resize the array and in that way it create problem with value"
2015-07-28 18:35:11 -05:00
Daniel Buckmaster
d268199f4f
Merge pull request #1339 from Areloch/Remove_Demo_Mode_Checks
...
Remove demo and trial checks
2015-07-23 20:33:31 +10:00
Areloch
527c3790d6
Issue found with PVS-Studio:
...
Many instances where we would create a object via a new call, and then check that it was non-null.
This is redundant, as if we ever were in a situation where new failed, we'd be crashing left and right already, so the additional check is wasted processing.
2015-07-21 23:22:21 -05:00
Daniel Buckmaster
4f2f1ca4e1
Merge pull request #1356 from Areloch/PVS_Cleanup_813
...
Convert un-modified function arguments to const references.
2015-07-20 22:55:22 +10:00
Daniel Buckmaster
c2e5dc3345
Merge remote-tracking branch 'bpay/clang-cl-build-fixes' into development
...
Conflicts:
Engine/source/T3D/shapeBase.h
2015-07-17 16:55:12 +10:00
Areloch
11398bb04e
Issue found with PVS-Studio:
...
A lot of instances where some function args are not actually modified in any way, meaning that it is better for performance to convert them into const references. This prevents an additional copy, which can help performance.
2015-07-16 22:02:18 -05:00
Daniel Buckmaster
86e0e67496
Merge pull request #1352 from Areloch/PVS_Cleanup_807
...
Unnecessarily repeated expressions
2015-07-16 15:45:32 +10:00
Areloch
5c688260d5
Issue found with PVS-Studio:
...
Many places utilize post-incrementation with iterators, but it's better performance to use pre-incrementation.
Resolved by changing the iter++ instances to ++iter;
2015-07-13 23:08:17 -05:00
Areloch
2002d74b78
Issue found with PVS-Studio:
...
Many instances of a function or expression being used repeatedly, which can lower performance.
Fixed it in these cases by creating on local var, reference or pointer that's used instead.
2015-07-13 22:51:17 -05:00
Areloch
0d6768d57b
Removing stuff pertaining to demo modes and trials, as they're redundant now.
2015-07-01 23:36:56 -05:00
James Urquhart
efc47ed757
Basic fix for stereo rendering without a display device
2015-06-21 20:59:41 +01:00
James Urquhart
3a457749ec
Oculus VR DK2 Support
...
- Updated to work with 0.5.x SDK
- Uses Oculus Rendering rather than PostFX
- Stereo rendering refactored so more rendering info is grabbed from the DisplayDevice
- Implements an Offscreen Canvas for in-game gui with oculus
- Message dialogs and metrics display can now go to the OffScreen Canvas (if oculus demo is setup correctly)
2015-05-06 23:09:51 +01:00
Areloch
6e681dd82f
Merge pull request #1239 from bpay/asan-fixes
...
Fix errors flagged by address sanitizer
2015-04-16 21:12:21 -05:00
LuisAntonRebollo
17f08e9f86
Fix bug on DefineConsoleMethod GuiCanvas::setVideoMode.
2015-03-14 13:01:05 +01:00
Ben Payne
16af2a126e
Add a comment
2015-03-06 15:36:22 -05:00
Ben Payne
01471c9ef3
Fix member function visibility
2015-03-04 19:25:10 -05:00
Ben Payne
bd49fe3cb0
Don't call strncpy when src == dest
...
This fixes an error flagged by address sanitizer
2015-03-04 19:13:53 -05:00
Ben Payne
62fa40380b
Fixes for "incomplete type" errors when compiling with clang-cl
2015-03-04 19:10:56 -05:00
Daniel Buckmaster
84e8cbb4ee
Revert recent style cleanup changes.
2015-03-04 11:58:36 +11:00
Daniel Buckmaster
33fcc59543
Merge remote-tracking branch 'origin/style-cleanup' into development
...
Conflicts:
Engine/source/T3D/tsStatic.cpp
Engine/source/console/compiledEval.cpp
Engine/source/ts/tsMesh.cpp
Engine/source/ts/tsShape.cpp
2015-03-01 22:30:22 +11:00
Daniel Buckmaster
6c92ab065e
Merge remote-tracking branch 'jamesu/console_stack_fix2' into development
...
Conflicts:
Engine/source/console/console.cpp
2015-03-01 20:33:29 +11:00
Daniel Buckmaster
497a15cfd0
Merge pull request #1214 from bpay/cppcheck-cleaning
...
Fix some issues flagged by cppcheck
2015-03-01 18:27:40 +11:00
Ben Payne
0ffd7f5620
Fix member vars left uninitialized in constructors
2015-02-20 18:41:51 -05:00
Antony Jones
d2d1f6086e
Added NULL check in function findItemByName.
...
(cherry picked from commit adb2513a2461092486e00b5550bf57fb83d0ccac)
2015-02-15 11:15:10 -08:00
Dennis Brakhane
b580b4a542
return the result value of scrollVisible
...
The console function changed from void to bool, so we
should actually return the value.
Also, the missing return is an error in VS2013.
2015-02-14 17:19:11 +01:00
Daniel Buckmaster
486a12cb96
Merge pull request #1183 from MusicMonkey5555/documentation
...
Documentation
2015-02-14 19:52:37 +11:00
Nathan Bowhay
0a345674ed
Fixed spacing issues
...
Tabs to 3 spaces.
2015-02-12 14:46:07 -08:00
Nathan Bowhay
dd46e800eb
Fixed spelling errors
...
Fixed spelling errors.
2015-02-12 14:14:10 -08:00
James Urquhart
f44a3f27d6
Fix stack balancing problems by refactoring execution calls
...
- Con::executef now uses a template
- All public execution functions now restore the console stack upon return
- Fixed bad parameters on some callbacks
- Reverts get*Arg behavior
2015-02-08 00:08:18 +00:00
Nathan Bowhay
4f87422392
Added console method docs and removed function
...
Added a ton of console method documenation and removed
getSelectionCentroidText when you can just use a Point3F as the return
type.
2015-02-02 16:27:03 -08:00
Nathan Bowhay
1ce846d235
add & delete object documentation
...
added add & delete object console method documentation.
2015-02-02 16:07:15 -08:00
Nathan Bowhay
72a0aed154
Some small console method docs
...
Added a little documentation to a console method.
2015-02-02 16:04:50 -08:00
Nathan Bowhay
881f9abeb6
Added console method docs
...
Added more console method documentation and made parameter names more
descriptive.
2015-02-02 15:39:11 -08:00
Nathan Bowhay
dd9b788ab4
More console method docs
...
More documentation for console methods in doxygen format.
2015-02-02 15:31:38 -08:00
Nathan Bowhay
a6510190bb
Added a bit more documentation
...
Added a little more documentation to some console methods.
2015-02-02 15:30:07 -08:00
Nathan Bowhay
879dbf0b03
Documented console methods
...
Added more documentation to console methods, changed inconsistent or
confusing parameter names.
2015-02-02 14:59:49 -08:00
Nathan Bowhay
fbc6bcea20
Added better comments to console methods
...
Improved the comments on two console methods so when using them it is
clearer what to expect.
2015-02-02 12:50:34 -08:00
Luis Anton Rebollo
cc9be50422
Merge pull request #1121 from bpay/fix-buffer-overflows
...
Fix buffer overflows
2015-02-02 20:15:51 +01:00
Daniel Buckmaster
014b566014
Merge remote-tracking branch 'gg/development-3.6' into development
...
Conflicts:
Engine/source/T3D/gameFunctions.cpp
2015-01-29 21:17:38 +11:00
Daniel Buckmaster
0605f056e3
Fix changes to moveSelection API.
2015-01-28 21:25:15 +11:00
Ben Payne
fcf52fb5e0
Rename the memory allocating versions to make prev error less likely
...
The behavior is different enough that these shouldn't be overloaded
with the non-allocating verions. Also makes it more obvious what is
going on to the caller.
2015-01-26 16:52:06 -05:00
Luis Anton Rebollo
6492028bb2
Merge pull request #1035 from bpay/memfixes
...
Memfixes
2015-01-25 13:42:32 +01:00
LuisAntonRebollo
4e9034854d
Linux implementation. Include changes for gcc x64.
2015-01-24 22:08:26 +01:00
LuisAntonRebollo
475f218bcd
Modified files for SDL2.
2015-01-18 22:52:29 +01:00
Daniel Buckmaster
f1da30f285
Those are ints, not floats.
2015-01-02 19:38:05 +11:00
Daniel Buckmaster
f9cd778b3b
Fixed tricky overloaded sfx* functions.
2014-12-24 10:04:44 +11:00
Daniel Buckmaster
3ab048c5b0
Fixes after feedback from Luis.
...
* Made use of dStrIsEmpty in more locations (and fixed it :P)
* Removed commented-out code
* Corrected default params
* Fixed some console warning formats
* Removed tabs
* Corrected setExtent API
2014-12-23 18:48:02 +11:00