Commit graph

606 commits

Author SHA1 Message Date
Areloch
527c3790d6 Issue found with PVS-Studio:
Many instances where we would create a object via a new call, and then check that it was non-null.

This is redundant, as if we ever were in a situation where new failed, we'd be crashing left and right already, so the additional check is wasted processing.
2015-07-21 23:22:21 -05:00
Azaezel
4bba5d87d0 partly addresses https://msdn.microsoft.com/en-us/library/y775w13y.aspx?f=255&MSPPError=-2147217396 violations 2015-07-16 21:51:37 -05:00
Areloch
5c688260d5 Issue found with PVS-Studio:
Many places utilize post-incrementation with iterators, but it's better performance to use pre-incrementation.

Resolved by changing the iter++ instances to ++iter;
2015-07-13 23:08:17 -05:00
Daniel Buckmaster
bac84eec3c Merge pull request #992 from Winterleaf/Fix-engineFunctions.h
Pragma pack for x32/x64
2015-07-12 16:17:45 +10:00
Daniel Buckmaster
5caf62b19f Merge pull request #1342 from Azaezel/Offsetof
offsetof is actually a standard thing nowadays it would seem
2015-07-05 11:26:53 +10:00
Raul Ferriz
5ef130d581 Fixed some random Worder warnings 2015-07-03 15:52:38 +02:00
Azaezel
5d89ab126d offsetof is actually a standard thing nowadays it would seem 2015-07-03 02:52:08 -05:00
Raul Ferriz
7e172869a9 Fixed warning.
Sort struct initialization to match fields declaration avoids a warnings on GCC.
2015-07-02 22:06:24 +02:00
Areloch
0d6768d57b Removing stuff pertaining to demo modes and trials, as they're redundant now. 2015-07-01 23:36:56 -05:00
Daniel Buckmaster
d89c3b7c6f Merge pull request #1333 from Azaezel/PluggingLeaks
Plugging Memory Leaks
2015-06-28 14:41:13 +10:00
Lopuska
03109c9d6d Color Picker 2015-06-24 20:36:30 -05:00
Areloch
6e8fa7215a Moves from using dStrIsEmpty to the new String::isEmpty static function. Keeps things cleaner, consistent, and works with intellisense. 2015-06-06 17:40:49 -05:00
Azaezel
b1e8a45a48 leak prevention according to: https://vld.codeplex.com/ ConsoleValue() constructors and destructors to handle corner-cases not already addressed via init, and cleanup 2015-06-02 14:25:08 -05:00
James Urquhart
d9436e65c5 Add workaround for issue #1292 2015-05-28 20:34:10 +10:00
James Urquhart
e5c28b4d7f Simplify buffer check when adding a registered variable 2015-05-16 14:57:40 +01:00
James Urquhart
15169eab9f Fix issue with registered variables becoming corrupted when string value was accessed. 2015-05-16 14:50:20 +01:00
James Urquhart
3a218217f4 Add workaround for issue #1292 2015-05-15 12:32:00 +01:00
James Urquhart
12d435c341 Remove value constructors for ConsoleValueRef & fix callbacks which use them. Fixes issue #1289 2015-05-08 09:04:04 +10:00
Daniel Buckmaster
84e8cbb4ee Revert recent style cleanup changes. 2015-03-04 11:58:36 +11:00
Daniel Buckmaster
33fcc59543 Merge remote-tracking branch 'origin/style-cleanup' into development
Conflicts:
	Engine/source/T3D/tsStatic.cpp
	Engine/source/console/compiledEval.cpp
	Engine/source/ts/tsMesh.cpp
	Engine/source/ts/tsShape.cpp
2015-03-01 22:30:22 +11:00
Daniel Buckmaster
57eed9c8e4 Amend console stack fixes to work with gcc in Ubuntu x64. 2015-03-01 20:34:16 +11:00
Daniel Buckmaster
6c92ab065e Merge remote-tracking branch 'jamesu/console_stack_fix2' into development
Conflicts:
	Engine/source/console/console.cpp
2015-03-01 20:33:29 +11:00
Daniel Buckmaster
497a15cfd0 Merge pull request #1214 from bpay/cppcheck-cleaning
Fix some issues flagged by cppcheck
2015-03-01 18:27:40 +11:00
Daniel Buckmaster
4aeaad91e7 Merge pull request #1218 from eightyeight/revert-1036
Revert "PR for issue #748"
2015-03-01 14:14:00 +11:00
Daniel Buckmaster
18cc91000e Merge pull request #1220 from eightyeight/fix-#396
Fix #396
2015-03-01 14:13:50 +11:00
Azaezel
54e1cceda9 Con::executef trampoline had mismatched argc values for the high end 2015-02-26 14:28:21 -06:00
Daniel Buckmaster
0bf021280e Regenerate parser. 2015-02-22 14:46:06 +11:00
Daniel Buckmaster
69ffe43b10 Fix docblock parsing rule.
We first require that the first character after a /// not be a newline,
in addition to it not being another /. Then we make the whole contents
of the line optional, so we can handle empty lines.
2015-02-22 14:44:48 +11:00
Daniel Buckmaster
ded87c0165 Revert "PR for issue #748"
This reverts commit 8518c85e80.
2015-02-22 12:47:00 +11:00
Ben Payne
591253d5b5 Fix missing va_end's 2015-02-20 18:42:29 -05:00
James Urquhart
942c7a48f4 Fix corruption issue with string iterator was using an absolute pointer. Also adds a special relative pointer type for constructed strings on the stack. 2015-02-16 21:23:42 +00:00
Daniel Buckmaster
486a12cb96 Merge pull request #1183 from MusicMonkey5555/documentation
Documentation
2015-02-14 19:52:37 +11:00
Nathan Bowhay
02f859c150 Fixed spacing to fit GG standards.
Fixed tabs to 3 spaces.
2015-02-11 10:53:34 -08:00
Nathan Bowhay
0007a518bc Corrected filesize units in return comment
I may be mistaken but at least in windows I think the return will be in
bytes no KB.
2015-02-11 09:53:45 -08:00
James Urquhart
97ab694af8 Add extra executef by popular demand 2015-02-10 22:36:09 +00:00
Daniel Buckmaster
7d4aeb8779 Merge pull request #1175 from Azaezel/linkNamespacesDebugOutput
feedback for *which* namespace is already linked.
2015-02-10 14:55:14 +11:00
Azaezel
fb79d1fec7 formatting 2015-02-09 21:53:44 -06:00
James Urquhart
3f97c2cedd Fix building on GCC 2015-02-09 16:14:14 +00:00
James Urquhart
4a97054f02 Workaround for GCC/LLVM 2015-02-08 11:22:17 +00:00
James Urquhart
1449c4df57 Add some tests for engineAPI and console 2015-02-08 00:08:19 +00:00
James Urquhart
94a46d7123 Regenerate engineAPI.h from a template 2015-02-08 00:08:19 +00:00
James Urquhart
f44a3f27d6 Fix stack balancing problems by refactoring execution calls
- Con::executef now uses a template
- All public execution functions now restore the console stack upon return
- Fixed bad parameters on some callbacks
- Reverts get*Arg behavior
2015-02-08 00:08:18 +00:00
LuisAntonRebollo
5d49771136 Fix FIELDOFFSET for OSX. 2015-02-07 16:41:55 +01:00
Ben Payne
c19a70814c Tidy up and fix the various Assert macros
Rephrase the macros so that they can be used in expressions, and
properly require semicolons. And add the semicolons where missing.
2015-02-02 18:37:48 -05:00
Nathan Bowhay
42126937e6 Fixed warning
Fixed a compile warning about casting.
2015-01-29 14:53:20 -08:00
Nathan Bowhay
d5a6e15cfe Fixed comment
fixed an incomplete comment/documentation for displaySplashWindow.
2015-01-29 14:43:02 -08:00
Nathan Bowhay
62b5c9fcfd Fixed issue with string replace
String replace doesn't always work correctly this fixes it.
2015-01-29 14:42:28 -08:00
Nathan Bowhay
df2ca75b13 get max dynamic verts in script
you can now get the max dynamic vertices in script.
2015-01-29 12:02:40 -08:00
Nathan Bowhay
5cfcb0cd45 fixed comment
added path param documentation to display splash window.
2015-01-29 11:59:06 -08:00
Nathan Bowhay
55b91606e6 Added more token functions
Added a bunch more token functions and added comments to word
equivalents to let you know about the token version.
2015-01-29 11:54:44 -08:00