Azaezel
1d442c9f84
void GuiTextEditCtrl::execConsoleCallback() reversion
...
see https://github.com/GarageGames/Torque3D/issues/1408
2015-09-16 12:55:27 -05:00
Areloch
bedc79aacb
Merges in Monkey's fixes PR with a resolution for a conflict
2015-09-03 22:58:57 -05:00
Azaezel
2238dd66da
From Dušan Jocić: early out of treeview entries to prevent crashes
...
"when you change some item or remove, it does not resize the array and in that way it create problem with value"
2015-07-28 18:35:11 -05:00
Areloch
527c3790d6
Issue found with PVS-Studio:
...
Many instances where we would create a object via a new call, and then check that it was non-null.
This is redundant, as if we ever were in a situation where new failed, we'd be crashing left and right already, so the additional check is wasted processing.
2015-07-21 23:22:21 -05:00
Daniel Buckmaster
4f2f1ca4e1
Merge pull request #1356 from Areloch/PVS_Cleanup_813
...
Convert un-modified function arguments to const references.
2015-07-20 22:55:22 +10:00
MusicMonkey5555
a22672dd7a
Update guiConsoleTextCtrl.cpp
...
Removed redundant assignment.
2015-07-17 16:40:39 -07:00
Areloch
11398bb04e
Issue found with PVS-Studio:
...
A lot of instances where some function args are not actually modified in any way, meaning that it is better for performance to convert them into const references. This prevents an additional copy, which can help performance.
2015-07-16 22:02:18 -05:00
Areloch
2002d74b78
Issue found with PVS-Studio:
...
Many instances of a function or expression being used repeatedly, which can lower performance.
Fixed it in these cases by creating on local var, reference or pointer that's used instead.
2015-07-13 22:51:17 -05:00
Ben Payne
16af2a126e
Add a comment
2015-03-06 15:36:22 -05:00
Ben Payne
bd49fe3cb0
Don't call strncpy when src == dest
...
This fixes an error flagged by address sanitizer
2015-03-04 19:13:53 -05:00
Daniel Buckmaster
6c92ab065e
Merge remote-tracking branch 'jamesu/console_stack_fix2' into development
...
Conflicts:
Engine/source/console/console.cpp
2015-03-01 20:33:29 +11:00
Daniel Buckmaster
497a15cfd0
Merge pull request #1214 from bpay/cppcheck-cleaning
...
Fix some issues flagged by cppcheck
2015-03-01 18:27:40 +11:00
Ben Payne
0ffd7f5620
Fix member vars left uninitialized in constructors
2015-02-20 18:41:51 -05:00
Antony Jones
d2d1f6086e
Added NULL check in function findItemByName.
...
(cherry picked from commit adb2513a2461092486e00b5550bf57fb83d0ccac)
2015-02-15 11:15:10 -08:00
Dennis Brakhane
b580b4a542
return the result value of scrollVisible
...
The console function changed from void to bool, so we
should actually return the value.
Also, the missing return is an error in VS2013.
2015-02-14 17:19:11 +01:00
Daniel Buckmaster
486a12cb96
Merge pull request #1183 from MusicMonkey5555/documentation
...
Documentation
2015-02-14 19:52:37 +11:00
Nathan Bowhay
0a345674ed
Fixed spacing issues
...
Tabs to 3 spaces.
2015-02-12 14:46:07 -08:00
Nathan Bowhay
246df9c454
Added parenthesis
...
Added parenthesis to avoid turning height into a true/false evaluation
result.
2015-02-12 08:25:16 -08:00
James Urquhart
f44a3f27d6
Fix stack balancing problems by refactoring execution calls
...
- Con::executef now uses a template
- All public execution functions now restore the console stack upon return
- Fixed bad parameters on some callbacks
- Reverts get*Arg behavior
2015-02-08 00:08:18 +00:00
Nathan Bowhay
879dbf0b03
Documented console methods
...
Added more documentation to console methods, changed inconsistent or
confusing parameter names.
2015-02-02 14:59:49 -08:00
Nathan Bowhay
77b9600303
IsActive fix & code cleanup
...
Now if a text edit is set to inactive you can't mouse down.
changed code
to use setVariable so code is a bit cleaner.
Fixed some small spacing
issues.
2015-02-02 13:54:56 -08:00
Nathan Bowhay
fbc6bcea20
Added better comments to console methods
...
Improved the comments on two console methods so when using them it is
clearer what to expect.
2015-02-02 12:50:34 -08:00
Nathan Bowhay
b11bc8e93a
Fixed some positioning bugs
...
Fixed some cursor positioning bugs in the MLTextCtrl.
Also removed parameters from function that doesn't actually take
parameters.
2015-02-02 12:17:38 -08:00
Nathan Bowhay
722008570a
Fixed bug with console expression result
...
Fixed a bug with the result of a console expression not always
displaying.
2015-02-02 12:02:56 -08:00
Luis Anton Rebollo
cc9be50422
Merge pull request #1121 from bpay/fix-buffer-overflows
...
Fix buffer overflows
2015-02-02 20:15:51 +01:00
Daniel Buckmaster
014b566014
Merge remote-tracking branch 'gg/development-3.6' into development
...
Conflicts:
Engine/source/T3D/gameFunctions.cpp
2015-01-29 21:17:38 +11:00
Ben Payne
fcf52fb5e0
Rename the memory allocating versions to make prev error less likely
...
The behavior is different enough that these shouldn't be overloaded
with the non-allocating verions. Also makes it more obvious what is
going on to the caller.
2015-01-26 16:52:06 -05:00
LuisAntonRebollo
4e9034854d
Linux implementation. Include changes for gcc x64.
2015-01-24 22:08:26 +01:00
Daniel Buckmaster
f9cd778b3b
Fixed tricky overloaded sfx* functions.
2014-12-24 10:04:44 +11:00
Daniel Buckmaster
3ab048c5b0
Fixes after feedback from Luis.
...
* Made use of dStrIsEmpty in more locations (and fixed it :P)
* Removed commented-out code
* Corrected default params
* Fixed some console warning formats
* Removed tabs
* Corrected setExtent API
2014-12-23 18:48:02 +11:00
Daniel Buckmaster
9396ae7176
Merge remote-tracking branch 'Winterleaf/Development-Console' into defineconsolemethod
...
Conflicts:
Engine/source/T3D/missionMarker.cpp
2014-12-21 21:23:55 +11:00
LuisAntonRebollo
2f8d18c0c0
Merge pull request #929 from BeamNG/remove_old_opengl_code
...
Remove unnecesary code for handle OpenGL.
2014-11-30 02:22:24 +01:00
LuisAntonRebollo
f101fbe820
Remove unnecesary code for handle OpenGL.
2014-11-08 18:11:35 +01:00
LuisAntonRebollo
cc16277ce6
Add GFXDevice::setupGenericShader for fix render on non FFP.
2014-11-08 17:59:36 +01:00
Vincent Gee
2f48f31a6f
Fixed String comparisons.
2014-11-05 23:29:08 -05:00
Vincent Gee
9907c4592e
Fixed bad string compares and simdictionary
2014-11-04 19:51:13 -05:00
Vincent Gee
acb192e2a5
Replaced a ton of ConsoleMethods with the DefineConsoleMethod Macro.
2014-11-03 22:42:51 -05:00
Daniel Buckmaster
b507dc9555
Merge branch 'master' into console-func-refactor
...
Conflicts:
Engine/source/app/net/net.cpp
Engine/source/console/astNodes.cpp
Engine/source/console/compiledEval.cpp
Engine/source/console/console.h
Engine/source/console/consoleInternal.h
Engine/source/console/engineAPI.h
2014-10-14 15:09:11 +11:00
Scott Przybylski
2987681220
Alternate fix for GuiTreeView
...
Adding `mFlags.set(RebuildVisible)` to `GuiTreeView::onWake()` fixes the problem where the tree is not drawn correctly when nodes are expanded in the TorqueScript `GuiTreeView::onWake()` callback function.
2014-08-14 21:52:48 -07:00
Scott Przybylski
e21a0876b6
GuiTreeView bug in buildVisibleTree
...
There was a bug in buildVisibleTree, it should be setting the RebuildVisible flag, not clearing it.
The clip rectangle did not appear to be updating when expanding items or calling scrollVisible, which expands all the items to make a particular item visible. This would cause part of the tree to be cut off.
Setting the RebuildVisible flag made the problem go away.
2014-08-14 00:59:07 -07:00
Daniel Buckmaster
b94679aebc
Prevent call to dStrlen(NULL).
2014-06-17 16:01:25 +10:00
bank
f3fc84738b
Use fixed buffer size var when allocating return buffer from console.
...
Conflicts:
Engine/source/T3D/missionArea.cpp
Engine/source/gui/editor/guiDebugger.cpp
2014-06-11 13:09:55 +04:00
Thomas Fischer
cd978039ac
Merge pull request #635 from just-bank/engine-fixes
...
Various engine fixes
2014-05-23 14:09:00 +02:00
Daniel Buckmaster
1702573b78
Merge pull request #612 from GarageGames/platform-type-consistency
...
Platform type consistency
2014-05-10 11:40:40 +10:00
bank
6275942acb
Fix GuiTreeViewCtrl: we should use the member var, removed local decl.
2014-05-06 15:39:22 +04:00
bank
6d176cf8db
Rename local variable to prevent confusion with member variable.
2014-05-06 15:39:21 +04:00
LuisAntonRebollo
7f46383eb5
Rename enum GFXTextureProfile::None for avoid conficts on Linux.
2014-04-07 00:03:52 +02:00
Daniel Buckmaster
87d9e245b7
Merge remote-tracking branch 'smally/platform_type_consistency' into platform-type-consistency
...
Conflicts:
Engine/source/platform/platformCPUCount.cpp
2014-04-04 13:43:25 +11:00
Daniel Buckmaster
dbb15ccf0b
Reformat parameter defaults to true.
2013-08-13 14:36:06 +10:00
cpusci
7a8f46b19f
Update for float, double and unsigned char, unsigned short, short, etc. char was left alone: read why here http://msdn.microsoft.com/en-us/library/cc953fe1.aspx
2013-08-04 16:58:59 -05:00