9 commits

Author	SHA1	Message	Date
Ben Payne	fcf52fb5e0	Rename the memory allocating versions to make prev error less likely ... The behavior is different enough that these shouldn't be overloaded with the non-allocating verions. Also makes it more obvious what is going on to the caller.	2015-01-26 16:52:06 -05:00
Ben Payne	d669eb6ee7	Fix unintentionally deleted param	2015-01-26 16:52:05 -05:00
Ben Payne	e3bbc42925	Provide a safer version of convertUTF16toUTF8	2015-01-26 16:52:01 -05:00
Ben Payne	a88339c219	Fix buffer overflows due to incorrect use of sizeof ... A snippet of example code: UTF16 pszFilter[1024]; ... convertUTF8toUTF16((UTF8 *)mData.mFilters, pszFilter, sizeof(pszFilter)); Since the conversion function is expecting the third parameter to be the length in 16-bit characters, *not* bytes, this results in the function writing outside the bounds of the output array. To make this less likely to happen in the future (I hope), I've provided a template function that infers the correct size of a static array, so it's no longer necessary to pass the size in most cases. The sized function has been renamed with an "N" suffix to hopefully encourage this use. This bug was caught due to a warning from MSVC about stack corruption occurring in codeBlock::exec(), after opening a file open dialog twice in succession. After some hunting, I found that this was due to FileDialog::Execute() passing incorrect buffer sizes to the conversion function, which resulted in the function writing a null terminator into some memory that happened to be in the stack frame of codeBlock::exec()!	2015-01-26 16:52:01 -05:00
Daniel Buckmaster	1702573b78	Merge pull request #612 from GarageGames/platform-type-consistency ... Platform type consistency	2014-05-10 11:40:40 +10:00
LuisAntonRebollo	4a17d6ceb0	Rename Status enum for avoid conficts on Linux.	2014-04-06 22:14:19 +02:00
cpusci	4c35fd37af	Simple pass over the codebase to standardize the platform types.	2013-08-04 16:26:01 -05:00
Tim Newell	31036c4031	Bug fixes for alternative zip layout and define to toggle it on	2013-02-28 16:46:46 -05:00
DavidWyand-GG	7dbfe6994d	Engine directory for ticket #1	2012-09-19 11:15:01 -04:00