Updated names of some of the input images to match the names of the inputs to simplify lookups

Altered a few of the input images to improve readability of some of the text
Standardizes the menuInputButton set usage to just use the raw action names rather than a middleman naming scheme for simplicity and standardization
Added comments to menuInputButtons.cs
Split out the menuInputButton containers to simplify and stabilize the code on the messageBox dialog
Removed old reference to script/gui files not there anymore
Simplified the input state check in guiGameListMenuCtrl.cpp
Added a check so we don't try exec'ing the selected list item in guiGameListMenuCtrl.cpp if nothing has actually be selected
This commit is contained in:
Areloch 2020-07-23 16:26:38 -05:00
parent 37420cda66
commit ef4cc8b573
18 changed files with 242 additions and 265 deletions

View file

@ -818,7 +818,7 @@ bool GuiGameListMenuCtrl::onInputEvent(const InputEventInfo& event)
{
bool isModifier = false;
bool state = event.action == SI_MAKE ? 1 : 0;
bool state = event.action == SI_MAKE;
switch (event.objInst)
{
@ -1164,7 +1164,7 @@ void GuiGameListMenuCtrl::changeOption(Row* row, S32 delta)
static StringTableEntry LEFT = StringTable->insert("LEFT", true);
static StringTableEntry RIGHT = StringTable->insert("RIGHT", true);
if (row->mScriptCallback != NULL)
if (row->mScriptCallback != NULL && row->mSelectedOption != NO_OPTION)
{
setThisControl();
StringTableEntry direction = NULL;