openfpsz/open-fpsz
1
0
Fork 0
mirror of https://gitlab.com/open-fpsz/open-fpsz.git synced 2026-07-14 07:56:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

♻️ Refactor Scoreboard code and improve UI

Browse source
This commit is contained in:
Squinty 2024-04-24 20:11:17 +00:00
parent 0c5d7c1338
commit 017ed4d560
6 changed files with 158 additions and 136 deletions
Download patch file Download diff file Expand all files Collapse all files

17
tests/test_scoreboard.gd
View file

@ -15,24 +15,25 @@
extends GutTest
var PLAYER : PackedScene = preload("res://entities/player/player.tscn")
var SCOREBOARD : PackedScene = preload("res://interfaces/hud/scoreboard.tscn")
var _subject : Scoreboard
func before_each() -> void:
_subject = Scoreboard.new()
_subject = SCOREBOARD.instantiate()
add_child(_subject)
func after_each() -> void:
_subject.free()
func test_that_new_scoreboard_is_empty() -> void:
assert_eq(_subject.get_entries(), [])
assert_eq(_subject._entries, {})
func test_that_added_entry_is_added_correctly() -> void:
var player : Player = PLAYER.instantiate()
player.nickname = "test_nickname"
_subject.add_entry(player)
var entries : Array = _subject.get_entries()
_subject.add_player(player)
var entries : Array = _subject._entries.values()
assert_eq(1, entries.size())
var tested_entry : Scoreboard.ScoreboardEntry = entries[0]
assert_eq("test_nickname", tested_entry.nickname)
@ -42,16 +43,16 @@ func test_that_added_entry_is_added_correctly() -> void:
func test_that_scores_are_added_correctly() -> void:
var player : Player = PLAYER.instantiate()
_subject.add_entry(player)
_subject.add_player(player)
_subject.add_score_to_player(player, 10)
var tested_entry : Scoreboard.ScoreboardEntry = _subject.get_entries()[0]
var tested_entry : Scoreboard.ScoreboardEntry = _subject._entries.values()[0]
assert_eq(10, tested_entry.score)
player.free()
func test_that_kill_counts_are_incremented_correctly() -> void:
var player : Player = PLAYER.instantiate()
_subject.add_entry(player)
_subject.add_player(player)
_subject.increment_kill_count(player)
var tested_entry : Scoreboard.ScoreboardEntry = _subject.get_entries()[0]
var tested_entry : Scoreboard.ScoreboardEntry = _subject._entries.values()[0]
assert_eq(1, tested_entry.kills)
player.free()