clang: constructor initialization order

while not a major issue per-se, the sheer number of times the engine has to jump back in memory and backfill data in a given class can add up. First run of... many.,

Engine/source/terrain/terrCell.cpp

@@ -49,11 +49,11 @@ const U32 TerrCell::smTriCount      = TerrCell::smPBSize / 3;              // 33
 
 
 TerrCell::TerrCell()
-   :  mMaterials( 0 ),
+   :  mTriCount( 0 ),
+      mHasEmpty( false ),
       mMaterial( NULL ),
-      mIsInteriorOnly( false ),
-      mTriCount( 0 ),
-      mHasEmpty( false )
+      mMaterials( 0 ),
+      mIsInteriorOnly( false )
 {
    dMemset( mChildren, 0, sizeof( mChildren ) );
 }

Engine/source/terrain/terrCellMaterial.cpp

@@ -69,8 +69,8 @@ Vector<String> _initSamplerNames()
 const Vector<String> TerrainCellMaterial::mSamplerNames = _initSamplerNames();
 
 TerrainCellMaterial::TerrainCellMaterial()
-   :  mCurrPass( 0 ),
-      mTerrain( NULL ),
+   :  mTerrain( NULL ),
+      mCurrPass( 0 ),
       mPrePassMat( NULL ),
       mReflectMat( NULL )
 {

Engine/source/terrain/terrData.cpp

@@ -180,23 +180,23 @@ ImplementEnumType(baseTexFormat,
 EndImplementEnumType;
 
 TerrainBlock::TerrainBlock()
- : mSquareSize( 1.0f ),
-   mCastShadows( true ),
-   mScreenError( 16 ),   
-   mDetailsDirty( false ),
-   mLayerTexDirty( false ),
-   mLightMap( NULL ),
+ : mLightMap( NULL ),
    mLightMapSize( 256 ),
-   mMaxDetailDistance( 0.0f ),
-   mCell( NULL ),
    mCRC( 0 ),
-   mBaseTexSize( 1024 ),
-   mBaseTexFormat( TerrainBlock::JPG ),
-   mBaseMaterial( NULL ),
-   mDefaultMatInst( NULL ),
+   mMaxDetailDistance( 0.0f ),
    mBaseTexScaleConst( NULL ),
    mBaseTexIdConst( NULL ),
+   mDetailsDirty( false ),
+   mLayerTexDirty( false ),
+   mBaseTexSize( 1024 ),
+   mBaseTexFormat( TerrainBlock::JPG ),
+   mCell( NULL ),
+   mBaseMaterial( NULL ),
+   mDefaultMatInst( NULL ),
+   mSquareSize( 1.0f ),
    mPhysicsRep( NULL ),
+   mScreenError( 16 ),
+   mCastShadows( true ),
    mZoningDirty( false )
 {
    mTypeMask = TerrainObjectType | StaticObjectType | StaticShapeObjectType;

Engine/source/terrain/terrFile.cpp

@@ -45,9 +45,9 @@ template<> ResourceBase::Signature Resource<TerrainFile>::signature()
 
 
 TerrainFile::TerrainFile()
-   : mNeedsResaving( false ),
+   : mSize( 256 ),
      mFileVersion( FILE_VERSION ),
-     mSize( 256 )
+     mNeedsResaving( false )
 {
    mLayerMap.setSize( mSize * mSize );
    dMemset( mLayerMap.address(), 0, mLayerMap.memSize() );

Engine/source/terrain/terrMaterial.cpp

@@ -57,11 +57,11 @@ ConsoleDocClass( TerrainMaterial,
 	"@ingroup enviroMisc\n");
 
 TerrainMaterial::TerrainMaterial()
-   :  mSideProjection( false ),
-      mDiffuseSize( 500.0f ),
+   :  mDiffuseSize( 500.0f ),
       mDetailSize( 5.0f ),
       mDetailStrength( 1.0f ),
       mDetailDistance( 50.0f ),
+      mSideProjection( false ),
       mMacroSize( 200.0f ),
       mMacroStrength( 0.7f ),
       mMacroDistance( 500.0f ),