From e03a86f75a511deee62818a62d4937fcd1e12a3c Mon Sep 17 00:00:00 2001 From: Glenn Smith Date: Tue, 6 Mar 2018 02:35:46 -0500 Subject: [PATCH] Actual buffer overflow bug found because of these fixes --- Engine/source/console/fileSystemFunctions.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Engine/source/console/fileSystemFunctions.cpp b/Engine/source/console/fileSystemFunctions.cpp index ec2d9c17d..0fdafec85 100644 --- a/Engine/source/console/fileSystemFunctions.cpp +++ b/Engine/source/console/fileSystemFunctions.cpp @@ -643,8 +643,8 @@ DefineEngineFunction(fileName, String, ( const char* fileName ),, name = szPathCopy; else name++; - char *ret = Con::getReturnBuffer(dStrlen(name)); - dStrcpy(ret, name, dStrlen(name)); + char *ret = Con::getReturnBuffer(dStrlen(name) + 1); + dStrcpy(ret, name, dStrlen(name) + 1); return ret; }