fixes and some minor bc adjustment.

This commit is contained in:
Jeff Hutchinson 2021-04-16 23:21:39 -04:00
parent bc0f5bd3a3
commit bfc0109485
7 changed files with 11 additions and 22 deletions

View file

@ -213,6 +213,7 @@ HEXDIGIT [a-fA-F0-9]
"true" { CMDlval.i = MakeToken< int >( 1, lineIndex ); return INTCONST; } "true" { CMDlval.i = MakeToken< int >( 1, lineIndex ); return INTCONST; }
"false" { CMDlval.i = MakeToken< int >( 0, lineIndex ); return INTCONST; } "false" { CMDlval.i = MakeToken< int >( 0, lineIndex ); return INTCONST; }
{VAR} { return(Sc_ScanVar()); } {VAR} { return(Sc_ScanVar()); }
{ID} { return Sc_ScanIdent(); } {ID} { return Sc_ScanIdent(); }
0[xX]{HEXDIGIT}+ return(Sc_ScanHex()); 0[xX]{HEXDIGIT}+ return(Sc_ScanHex());
{INTEGER} { CMDtext[CMDleng] = 0; CMDlval.i = MakeToken< int >( dAtoi(CMDtext), lineIndex ); return INTCONST; } {INTEGER} { CMDtext[CMDleng] = 0; CMDlval.i = MakeToken< int >( dAtoi(CMDtext), lineIndex ); return INTCONST; }

View file

@ -165,7 +165,7 @@ static U32 conversionOp(TypeReq src, TypeReq dst)
case TypeReqString: case TypeReqString:
return OP_FLT_TO_STR; return OP_FLT_TO_STR;
case TypeReqNone: case TypeReqNone:
return OP_FLT_TO_NONE; return OP_NUM_TO_NONE;
default: default:
break; break;
} }
@ -179,7 +179,7 @@ static U32 conversionOp(TypeReq src, TypeReq dst)
case TypeReqString: case TypeReqString:
return OP_UINT_TO_STR; return OP_UINT_TO_STR;
case TypeReqNone: case TypeReqNone:
return OP_UINT_TO_NONE; return OP_NUM_TO_NONE;
default: default:
break; break;
} }

View file

@ -1215,12 +1215,6 @@ void CodeBlock::dumpInstructions(U32 startIp, bool upToReturn)
break; break;
} }
case OP_FLT_TO_NONE:
{
Con::printf("%i: OP_FLT_TO_NONE", ip - 1);
break;
}
case OP_UINT_TO_FLT: case OP_UINT_TO_FLT:
{ {
Con::printf("%i: OP_UINT_TO_FLT", ip - 1); Con::printf("%i: OP_UINT_TO_FLT", ip - 1);
@ -1233,9 +1227,9 @@ void CodeBlock::dumpInstructions(U32 startIp, bool upToReturn)
break; break;
} }
case OP_UINT_TO_NONE: case OP_NUM_TO_NONE:
{ {
Con::printf("%i: OP_UINT_TO_NONE", ip - 1); Con::printf("%i: OP_NUM_TO_NONE", ip - 1);
break; break;
} }

View file

@ -1547,10 +1547,6 @@ ConsoleValue CodeBlock::exec(U32 ip, const char* functionName, Namespace* thisNa
_STK--; _STK--;
break; break;
case OP_FLT_TO_NONE:
_STK--;
break;
case OP_UINT_TO_FLT: case OP_UINT_TO_FLT:
numStack[_STK].f = (F64)numStack[_STK].i; numStack[_STK].f = (F64)numStack[_STK].i;
break; break;
@ -1560,7 +1556,7 @@ ConsoleValue CodeBlock::exec(U32 ip, const char* functionName, Namespace* thisNa
_STK--; _STK--;
break; break;
case OP_UINT_TO_NONE: case OP_NUM_TO_NONE:
_STK--; _STK--;
break; break;

View file

@ -137,10 +137,9 @@ namespace Compiler
OP_STR_TO_NONE, // 60 OP_STR_TO_NONE, // 60
OP_FLT_TO_UINT, OP_FLT_TO_UINT,
OP_FLT_TO_STR, OP_FLT_TO_STR,
OP_FLT_TO_NONE,
OP_UINT_TO_FLT, OP_UINT_TO_FLT,
OP_UINT_TO_STR, OP_UINT_TO_STR,
OP_UINT_TO_NONE, OP_NUM_TO_NONE,
OP_LOADIMMED_UINT, OP_LOADIMMED_UINT,
OP_LOADIMMED_FLT, OP_LOADIMMED_FLT,

View file

@ -2595,7 +2595,7 @@ ConsoleValue _BaseEngineConsoleCallbackHelper::_exec()
// Cannot invoke callback until object has been registered // Cannot invoke callback until object has been registered
if (mThis->isProperlyAdded()) if (mThis->isProperlyAdded())
{ {
ConsoleValue returnValue = std::move(Con::_internalExecute( mThis, mArgc, mArgv, false )); ConsoleValue returnValue = Con::_internalExecute( mThis, mArgc, mArgv, false );
mArgc = mInitialArgc; // reset mArgc = mInitialArgc; // reset
return std::move(returnValue); return std::move(returnValue);
} }

View file

@ -175,14 +175,14 @@ class ConsoleValue
} }
public: public:
ConsoleValue() explicit ConsoleValue()
{ {
setEmptyString(); type = ConsoleValueType::cvSTEntry;
s = const_cast<char*>(StringTable->EmptyString());
} }
ConsoleValue(ConsoleValue&& ref) noexcept ConsoleValue(ConsoleValue&& ref) noexcept
{ {
cleanupData();
type = ref.type; type = ref.type;
switch (ref.type) switch (ref.type)
@ -217,7 +217,6 @@ public:
TORQUE_FORCEINLINE void reset() TORQUE_FORCEINLINE void reset()
{ {
cleanupData();
setEmptyString(); setEmptyString();
} }