TorqueGameEngines/Torque3D
1
0
Fork 0
mirror of https://github.com/TorqueGameEngines/Torque3D.git synced 2026-07-14 08:04:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove comments.

Browse source
This commit is contained in:
Daniel Buckmaster 2015-05-09 15:02:41 +10:00
parent f3199b04e4
commit ae4ac53592
2 changed files with 1 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Engine/source/platform/platformIntrinsics.gcc.h
View file

@ -42,7 +42,6 @@ inline void dFetchAndAdd( volatile U32& ref, U32 val )
#if defined(TORQUE_OS_PS3) #if defined(TORQUE_OS_PS3)
cellAtomicAdd32( (std::uint32_t *)&ref, val ); cellAtomicAdd32( (std::uint32_t *)&ref, val );
#elif !defined(TORQUE_OS_MAC) #elif !defined(TORQUE_OS_MAC)
//__sync_fetch_and_add( ( volatile long* ) &ref, val );
__sync_fetch_and_add(&ref, val ); __sync_fetch_and_add(&ref, val );
#else #else
OSAtomicAdd32( val, (int32_t* ) &ref); OSAtomicAdd32( val, (int32_t* ) &ref);
@ -54,7 +53,6 @@ inline void dFetchAndAdd( volatile S32& ref, S32 val )
#if defined(TORQUE_OS_PS3) #if defined(TORQUE_OS_PS3)
cellAtomicAdd32( (std::uint32_t *)&ref, val ); cellAtomicAdd32( (std::uint32_t *)&ref, val );
#elif !defined(TORQUE_OS_MAC) #elif !defined(TORQUE_OS_MAC)
//__sync_fetch_and_add( ( volatile long* ) &ref, val );
__sync_fetch_and_add( &ref, val ); __sync_fetch_and_add( &ref, val );
#else #else
OSAtomicAdd32( val, (int32_t* ) &ref); OSAtomicAdd32( val, (int32_t* ) &ref);

13
Engine/source/platform/threads/threadPool.cpp
View file

@ -412,18 +412,7 @@ void ThreadPool::queueWorkItem( WorkItem* item )
mWorkItemQueue.insert( item->getPriority(), item ); mWorkItemQueue.insert( item->getPriority(), item );
// Wake up some thread, if we need to. mSemaphore.release();
// Use the ready count here as the wake count does
// not correctly protect the critical section in the
// thread's run function. This may lead us to release
// the semaphore more often than necessary, but it avoids
// a race condition.
//Wasn't there still a race condition? Why not rely entirely on the semaphore?
//For example, mNumThreadsReady initializes equalto mNumThreads, which could cause
//initial work items to hang.
//if( !dCompareAndSwap( mNumThreadsReady, mNumThreads, mNumThreads ) )
mSemaphore.release();
} }
} }