Merge pull request #397 from Areloch/GuiGameMenuCtrlSanityCleanup

Removes unneeded redundant asserts when the functions already have range sanity checks
This commit is contained in:
Brian Roberts 2020-12-04 16:39:30 -06:00 committed by GitHub
commit a41e0d5160
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -1006,7 +1006,6 @@ void GuiGameListMenuCtrl::setThisControl()
StringTableEntry GuiGameListMenuCtrl::getRowLabel(S32 rowIndex) const
{
AssertFatal(isValidRowIndex(rowIndex), avar("GuiGameListMenuCtrl: You can't get the label from row %d of %s because it is not a valid row index. Please specify a valid row index in the range [0, %d).", rowIndex, getName(), getRowCount()));
if (! isValidRowIndex(rowIndex))
{
// not a valid row index, don't do anything
@ -1017,7 +1016,6 @@ StringTableEntry GuiGameListMenuCtrl::getRowLabel(S32 rowIndex) const
void GuiGameListMenuCtrl::setRowLabel(S32 rowIndex, const char * label)
{
AssertFatal(isValidRowIndex(rowIndex), avar("GuiGameListMenuCtrl: You can't set the label on row %d of %s because it is not a valid row index. Please specify a valid row index in the range [0, %d).", rowIndex, getName(), getRowCount()));
if (! isValidRowIndex(rowIndex))
{
// not a valid row index, don't do anything