Merge pull request #1633 from Azaezel/alpha41/dsqFindings
Some checks are pending
Linux Build / ${{matrix.config.name}} (map[build_type:Release cc:gcc cxx:g++ generator:Ninja name:Ubuntu Latest GCC]) (push) Waiting to run
MacOSX Build / ${{matrix.config.name}} (map[build_type:Release cc:clang cxx:clang++ generator:Ninja name:MacOSX Latest Clang]) (push) Waiting to run
Windows Build / ${{matrix.config.name}} (map[build_type:Release cc:cl cxx:cl environment_script:C:/Program Files (x86)/Microsoft Visual Studio/2022/Enterprise/VC/Auxiliary/Build/vcvars64.bat generator:Visual Studio 17 2022 name:Windows Latest MSVC]) (push) Waiting to run

dsq followup work 1
This commit is contained in:
Brian Roberts 2025-12-22 16:47:35 -06:00 committed by GitHub
commit a181f488b2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 127 additions and 46 deletions

View file

@ -69,6 +69,7 @@
# define new _new # define new _new
#endif #endif
extern bool gTryUseDSQs;
MODULE_BEGIN( AssimpShapeLoader ) MODULE_BEGIN( AssimpShapeLoader )
MODULE_INIT_AFTER( ShapeLoader ) MODULE_INIT_AFTER( ShapeLoader )
@ -664,13 +665,12 @@ bool AssimpShapeLoader::fillGuiTreeView(const char* sourceShapePath, GuiTreeView
return true; return true;
} }
/// Check if an up-to-date cached DTS is available for this DAE file /// Check if an up-to-date cached DTS is available for this file
bool AssimpShapeLoader::canLoadCachedDTS(const Torque::Path& path) bool AssimpShapeLoader::canLoadCachedDTS(const Torque::Path& path)
{ {
// Generate the cached filename // Generate the cached filename
Torque::Path cachedPath(path); Torque::Path cachedPath(path);
if (String::compare(path.getExtension(), "dsq") != 0) cachedPath.setExtension("cached.dts");
cachedPath.setExtension("cached.dts");
// Check if a cached DTS newer than this file is available // Check if a cached DTS newer than this file is available
FileTime cachedModifyTime; FileTime cachedModifyTime;
@ -689,6 +689,30 @@ bool AssimpShapeLoader::canLoadCachedDTS(const Torque::Path& path)
return false; return false;
} }
/// Check if an up-to-date cached DSQ is available for this file
bool AssimpShapeLoader::canLoadCachedDSQ(const Torque::Path& path)
{
// Generate the cached filename
Torque::Path cachedPath(path);
cachedPath.setExtension("dsq");
// Check if a cached DTS newer than this file is available
FileTime cachedModifyTime;
if (Platform::getFileTimes(cachedPath.getFullPath(), NULL, &cachedModifyTime))
{
bool forceLoad = Con::getBoolVariable("$assimp::forceLoad", false);
FileTime daeModifyTime;
if (!Platform::getFileTimes(path.getFullPath(), NULL, &daeModifyTime) ||
(!forceLoad && (Platform::compareFileTimes(cachedModifyTime, daeModifyTime) >= 0)))
{
// Original file not found, or cached DTS is newer
return true;
}
}
return false;
}
void AssimpShapeLoader::assimpLogCallback(const char* message, char* user) void AssimpShapeLoader::assimpLogCallback(const char* message, char* user)
{ {
Con::printf("[Assimp log message] %s", StringUnit::getUnit(message, 0, "\n")); Con::printf("[Assimp log message] %s", StringUnit::getUnit(message, 0, "\n"));
@ -973,30 +997,37 @@ TSShape* assimpLoadShape(const Torque::Path &path)
// TODO: add .cached.dts generation. // TODO: add .cached.dts generation.
// Generate the cached filename // Generate the cached filename
Torque::Path cachedPath(path); Torque::Path cachedPath(path);
if ( String::compare(path.getExtension(),"dsq") != 0) bool canLoadCached = false;
cachedPath.setExtension("cached.dts"); bool canLoadDSQ = false;
// Check if an up-to-date cached DTS version of this file exists, and // Check if an up-to-date cached DTS version of this file exists, and
// if so, use that instead. // if so, use that instead.
if (AssimpShapeLoader::canLoadCachedDTS(path)) if (AssimpShapeLoader::canLoadCachedDTS(path))
{
cachedPath.setExtension("cached.dts");
canLoadCached = true;
}
else if (gTryUseDSQs && AssimpShapeLoader::canLoadCachedDSQ(path))
{
cachedPath.setExtension("dsq");
canLoadDSQ = true;
}
if (canLoadCached || canLoadDSQ)
{ {
FileStream cachedStream; FileStream cachedStream;
cachedStream.open(cachedPath.getFullPath(), Torque::FS::File::Read); cachedStream.open(cachedPath.getFullPath(), Torque::FS::File::Read);
if (cachedStream.getStatus() == Stream::Ok) if (cachedStream.getStatus() == Stream::Ok)
{ {
TSShape *shape = new TSShape; TSShape *shape = new TSShape;
if (String::compare(path.getExtension(), "dsq") == 0) bool readSuccess = false;
if (canLoadCached)
{ {
if (!shape->importSequences(&cachedStream, cachedPath.getFullPath())) readSuccess = shape->read(&cachedStream);
{ }
Con::errorf("assimpLoadShape: Load sequence file '%s' failed", cachedPath.getFullPath().c_str()); else
delete shape; {
shape = NULL; readSuccess = shape->importSequences(&cachedStream, cachedPath);
}
cachedStream.close();
return shape;
} }
bool readSuccess = shape->read(&cachedStream);
cachedStream.close(); cachedStream.close();
if (readSuccess) if (readSuccess)
@ -1007,10 +1038,13 @@ TSShape* assimpLoadShape(const Torque::Path &path)
return shape; return shape;
} }
else else
{
#ifdef TORQUE_DEBUG
Con::errorf("assimpLoadShape: Load sequence file '%s' failed", cachedPath.getFullPath().c_str());
#endif
delete shape; delete shape;
}
} }
Con::warnf("Failed to load cached shape from %s", cachedPath.getFullPath().c_str());
} }
if (!Torque::FS::IsFile(path)) if (!Torque::FS::IsFile(path))
@ -1041,27 +1075,22 @@ TSShape* assimpLoadShape(const Torque::Path &path)
realMesh = true; realMesh = true;
} }
if (!realMesh) if (!realMesh && gTryUseDSQs)
{ {
Torque::Path dsqPath(cachedPath); Torque::Path dsqPath(cachedPath);
dsqPath.setExtension("dsq"); dsqPath.setExtension("dsq");
FileStream animOutStream; FileStream animOutStream;
for (S32 i = 0; i < tss->sequences.size(); i++) dsqPath.setFileName(cachedPath.getFileName());
if (animOutStream.open(dsqPath.getFullPath(), Torque::FS::File::Write))
{ {
const String& seqName = tss->getName(tss->sequences[i].nameIndex); Con::printf("Writing DSQ Animation File for '%s'", dsqPath.getFileName().c_str());
Con::printf("Writing DSQ Animation File for sequence '%s'", seqName.c_str()); tss->exportSequences(&animOutStream);
dsqPath.setFileName(cachedPath.getFileName() + "_" + seqName);
if (animOutStream.open(dsqPath.getFullPath(), Torque::FS::File::Write))
{
tss->exportSequence(&animOutStream, tss->sequences[i], false);
animOutStream.close();
}
} }
} }
else else
{ {
// Cache the model to a DTS file for faster loading next time.
cachedPath.setExtension("cached.dts");
// Cache the model to a DTS file for faster loading next time. // Cache the model to a DTS file for faster loading next time.
FileStream dtsStream; FileStream dtsStream;
if (dtsStream.open(cachedPath.getFullPath(), Torque::FS::File::Write)) if (dtsStream.open(cachedPath.getFullPath(), Torque::FS::File::Write))

View file

@ -79,6 +79,7 @@ public:
bool fillGuiTreeView(const char* shapePath, GuiTreeViewCtrl* tree); bool fillGuiTreeView(const char* shapePath, GuiTreeViewCtrl* tree);
static bool canLoadCachedDTS(const Torque::Path& path); static bool canLoadCachedDTS(const Torque::Path& path);
static bool canLoadCachedDSQ(const Torque::Path& path);
static void assimpLogCallback(const char* message, char* user); static void assimpLogCallback(const char* message, char* user);
}; };

View file

@ -50,6 +50,7 @@
#include "core/util/zip/zipVolume.h" #include "core/util/zip/zipVolume.h"
#include "gfx/bitmap/gBitmap.h" #include "gfx/bitmap/gBitmap.h"
extern bool gTryUseDSQs;
MODULE_BEGIN( ColladaShapeLoader ) MODULE_BEGIN( ColladaShapeLoader )
MODULE_INIT_AFTER( ShapeLoader ) MODULE_INIT_AFTER( ShapeLoader )
MODULE_INIT MODULE_INIT
@ -548,7 +549,39 @@ bool ColladaShapeLoader::canLoadCachedDTS(const Torque::Path& path)
return false; return false;
} }
bool ColladaShapeLoader::canLoadCachedDSQ(const Torque::Path& path)
{
// Generate the cached filename
Torque::Path cachedPath(path);
cachedPath.setExtension("dsq");
// Check if a cached DSQ newer than this file is available
FileTime cachedModifyTime;
if (Platform::getFileTimes(cachedPath.getFullPath(), NULL, &cachedModifyTime))
{
bool forceLoadDAE = Con::getBoolVariable("$collada::forceLoadDAE", false);
FileTime daeModifyTime;
if (!Platform::getFileTimes(path.getFullPath(), NULL, &daeModifyTime) ||
(!forceLoadDAE && (Platform::compareFileTimes(cachedModifyTime, daeModifyTime) >= 0)))
{
// DAE not found, or cached DTS is newer
return true;
}
}
//assume the dts is good since it was zipped on purpose
Torque::FS::FileSystemRef ref = Torque::FS::GetFileSystem(cachedPath);
if (ref && !String::compare("Zip", ref->getTypeStr().c_str()))
{
bool forceLoadDAE = Con::getBoolVariable("$collada::forceLoadDAE", false);
if (!forceLoadDAE && Torque::FS::IsFile(cachedPath))
return true;
}
return false;
}
bool ColladaShapeLoader::checkAndMountSketchup(const Torque::Path& path, String& mountPoint, Torque::Path& daePath) bool ColladaShapeLoader::checkAndMountSketchup(const Torque::Path& path, String& mountPoint, Torque::Path& daePath)
{ {
bool isSketchup = path.getExtension().equal("kmz", String::NoCase); bool isSketchup = path.getExtension().equal("kmz", String::NoCase);
@ -655,18 +688,36 @@ TSShape* loadColladaShape(const Torque::Path &path)
#ifndef DAE2DTS_TOOL #ifndef DAE2DTS_TOOL
// Generate the cached filename // Generate the cached filename
Torque::Path cachedPath(path); Torque::Path cachedPath(path);
cachedPath.setExtension("cached.dts"); bool canLoadCached = false;
bool canLoadDSQ = false;
// Check if an up-to-date cached DTS version of this file exists, and // Check if an up-to-date cached DTS version of this file exists, and
// if so, use that instead. // if so, use that instead.
if (ColladaShapeLoader::canLoadCachedDTS(path)) if (ColladaShapeLoader::canLoadCachedDTS(path))
{
cachedPath.setExtension("cached.dts");
canLoadCached = true;
}
else if (gTryUseDSQs && ColladaShapeLoader::canLoadCachedDSQ(path))
{
cachedPath.setExtension("dsq");
canLoadDSQ = true;
}
if (canLoadCached || canLoadDSQ)
{ {
FileStream cachedStream; FileStream cachedStream;
cachedStream.open(cachedPath.getFullPath(), Torque::FS::File::Read); cachedStream.open(cachedPath.getFullPath(), Torque::FS::File::Read);
if (cachedStream.getStatus() == Stream::Ok) if (cachedStream.getStatus() == Stream::Ok)
{ {
TSShape *shape = new TSShape; TSShape *shape = new TSShape;
bool readSuccess = shape->read(&cachedStream); bool readSuccess = false;
if (canLoadCached)
{
readSuccess = shape->read(&cachedStream);
}
else
{
readSuccess = shape->importSequences(&cachedStream, cachedPath);
}
cachedStream.close(); cachedStream.close();
if (readSuccess) if (readSuccess)
@ -677,10 +728,13 @@ TSShape* loadColladaShape(const Torque::Path &path)
return shape; return shape;
} }
else else
{
#ifdef TORQUE_DEBUG
Con::errorf("loadColladaShape: Load sequence file '%s' failed", cachedPath.getFullPath().c_str());
#endif
delete shape; delete shape;
}
} }
Con::warnf("Failed to load cached COLLADA shape from %s", cachedPath.getFullPath().c_str());
} }
#endif // DAE2DTS_TOOL #endif // DAE2DTS_TOOL
@ -732,28 +786,23 @@ TSShape* loadColladaShape(const Torque::Path &path)
realMesh = true; realMesh = true;
} }
if (!realMesh) if (!realMesh && gTryUseDSQs)
{ {
Torque::Path dsqPath(cachedPath); Torque::Path dsqPath(cachedPath);
dsqPath.setExtension("dsq"); dsqPath.setExtension("dsq");
FileStream animOutStream; FileStream animOutStream;
for (S32 i = 0; i < tss->sequences.size(); i++) dsqPath.setFileName(cachedPath.getFileName());
if (animOutStream.open(dsqPath.getFullPath(), Torque::FS::File::Write))
{ {
const String& seqName = tss->getName(tss->sequences[i].nameIndex); Con::printf("Writing DSQ Animation File for '%s'", dsqPath.getFileName().c_str());
Con::printf("Writing DSQ Animation File for sequence '%s'", seqName.c_str()); tss->exportSequences(&animOutStream);
animOutStream.close();
dsqPath.setFileName(cachedPath.getFileName() + "_" + seqName);
if (animOutStream.open(dsqPath.getFullPath(), Torque::FS::File::Write))
{
tss->exportSequence(&animOutStream, tss->sequences[i], false);
animOutStream.close();
}
} }
} }
else else
{ {
// Cache the Collada model to a DTS file for faster loading next time. // Cache the Collada model to a DTS file for faster loading next time.
cachedPath.setExtension("cached.dts");
FileStream dtsStream; FileStream dtsStream;
if (dtsStream.open(cachedPath.getFullPath(), Torque::FS::File::Write)) if (dtsStream.open(cachedPath.getFullPath(), Torque::FS::File::Write))
{ {

View file

@ -53,6 +53,7 @@ public:
void computeBounds(Box3F& bounds) override; void computeBounds(Box3F& bounds) override;
static bool canLoadCachedDTS(const Torque::Path& path); static bool canLoadCachedDTS(const Torque::Path& path);
static bool canLoadCachedDSQ(const Torque::Path& path);
static bool checkAndMountSketchup(const Torque::Path& path, String& mountPoint, Torque::Path& daePath); static bool checkAndMountSketchup(const Torque::Path& path, String& mountPoint, Torque::Path& daePath);
static domCOLLADA* getDomCOLLADA(const Torque::Path& path); static domCOLLADA* getDomCOLLADA(const Torque::Path& path);
static domCOLLADA* readColladaFile(const String& path); static domCOLLADA* readColladaFile(const String& path);

View file

@ -40,6 +40,7 @@ MODULE_BEGIN( ShapeLoader )
} }
MODULE_END; MODULE_END;
bool gTryUseDSQs = false;
const F32 TSShapeLoader::DefaultTime = -1.0f; const F32 TSShapeLoader::DefaultTime = -1.0f;
const F64 TSShapeLoader::MinFrameRate = 15.0f; const F64 TSShapeLoader::MinFrameRate = 15.0f;
const F64 TSShapeLoader::MaxFrameRate = 60.0f; const F64 TSShapeLoader::MaxFrameRate = 60.0f;