TorqueGameEngines/Torque3D
1
0
Fork 0
mirror of https://github.com/TorqueGameEngines/Torque3D.git synced 2026-07-15 16:44:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

clang catch: boxBase's getPlanePointIndex method wasn't returning values in all cases.

Browse source 
assertfatal doesn't do anything in release builds, so also added a failure enum.
This commit is contained in:
Azaezel 2016-10-16 15:31:56 -05:00
parent 3038e53856
commit 8d4dd14144
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Engine/source/math/mBoxBase.h
View file

@ -49,7 +49,8 @@ class BoxBase
FarTopLeft, FarTopLeft,
FarBottomLeft, FarBottomLeft,
NUM_POINTS NUM_POINTS,
InvalidPoint = NUM_POINTS
}; };
/// Return the point index for the opposite corner of @a p. /// Return the point index for the opposite corner of @a p.
@ -192,8 +193,6 @@ class BoxBase
default: AssertFatal( false, "BoxBase::getPlanePointIndex - Invalid index" ); default: AssertFatal( false, "BoxBase::getPlanePointIndex - Invalid index" );
} }
break; break;
default:
AssertFatal( false, "BoxBase::getPlanePointIndex - Invalid plane" );
case BottomPlane: case BottomPlane:
switch( i ) switch( i )
{ {
@ -204,7 +203,10 @@ class BoxBase
default: AssertFatal( false, "BoxBase::getPlanePointIndex - Invalid index" ); default: AssertFatal( false, "BoxBase::getPlanePointIndex - Invalid index" );
} }
break; break;
default:
AssertFatal( false, "BoxBase::getPlanePointIndex - Invalid plane" );
} }
return InvalidPoint;
} }
/// Indices for the edges of the box. /// Indices for the edges of the box.