TorqueGameEngines/Torque3D
1
0
Fork 0
mirror of https://github.com/TorqueGameEngines/Torque3D.git synced 2026-07-11 22:54:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Various misc. tweaks and fixes based on static code analysis to minimize/fix memleaks, crashes, or other performance impacting code.

Browse source
This commit is contained in:
Areloch 2020-09-19 18:25:10 -05:00
parent d76c73c252
commit 8956559bfd
44 changed files with 124 additions and 258 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Engine/source/ts/collada/colladaUtils.cpp
View file

@ -770,6 +770,8 @@ static void conditioner_createDefaultClip(domCOLLADA* root)
static void conditioner_fixupAnimation(domAnimation* anim)
{
S32 visibilityLen = dStrlen("/visibility");
for (S32 iChannel = 0; iChannel < anim->getChannel_array().getCount(); iChannel++) {
// Get the animation elements: <channel>, <sampler>
@ -815,7 +817,7 @@ static void conditioner_fixupAnimation(domAnimation* anim)
// Get parent SID string
char *parentSID = dStrdup(channel->getTarget());
parentSID[dStrlen(parentSID) - dStrlen("/visibility")] = '\0';
parentSID[dStrlen(parentSID) - visibilityLen] = '\0';
// Find the parent element (should be a <node>)
daeSIDResolver parentResolver(channel, parentSID);
@ -3039,4 +3041,4 @@ void ColladaUtils::ExportData::processData()
}
}
}
}
}

3
Engine/source/ts/tsDump.cpp
View file

@ -64,6 +64,7 @@ void TSShapeInstance::dumpNode(Stream & stream ,S32 level, S32 nodeIndex, Vector
if (objectList.size() == 0)
dumpLine("\r\n");
S32 nodeNameLen = dStrlen(nodeName);
S32 spaceCount = -1;
for (S32 j=0;j<objectList.size(); j++)
{
@ -101,7 +102,7 @@ void TSShapeInstance::dumpNode(Stream & stream ,S32 level, S32 nodeIndex, Vector
// how many spaces should we prepend if we have another object on this node
if (spaceCount<0)
spaceCount = (S32)(dStrlen(space) + dStrlen(nodeName));
spaceCount = (S32)(dStrlen(space) + nodeNameLen);
if(spaceCount > 2000)
spaceCount = 2000;

2
Engine/source/ts/tsShapeConstruct.cpp
View file

@ -424,6 +424,8 @@ bool TSShapeConstructor::onAdd()
group = new SimGroup();
if ( !group->registerObject("TSShapeConstructorGroup") )
{
SAFE_DELETE(group);
Con::errorf("TSShapeConstructor::onAdd failed: Could not register "
"TSShapeConstructorGroup");
return false;