From 7a61a3cd95d1beafb9e92c01ba623516fd0f19f5 Mon Sep 17 00:00:00 2001 From: Glenn Smith Date: Fri, 30 Mar 2018 02:27:43 -0400 Subject: [PATCH 1/2] Badly sized buffer in dumpConsoleClasses --- Engine/source/console/consoleDoc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Engine/source/console/consoleDoc.cpp b/Engine/source/console/consoleDoc.cpp index f4b74402b..d9ff78020 100644 --- a/Engine/source/console/consoleDoc.cpp +++ b/Engine/source/console/consoleDoc.cpp @@ -88,7 +88,7 @@ void printClassHeader(const char* usage, const char * className, const char * su if((usage != NULL) && strlen(usage)) { // Copy Usage Document - S32 usageLen = dStrlen( usage ); + S32 usageLen = dStrlen( usage ) + 1; FrameTemp usageStr( usageLen ); dStrcpy( usageStr, usage, usageLen ); From 50ac969b48cdc64611e65bf586386ab15286f8ab Mon Sep 17 00:00:00 2001 From: Glenn Smith Date: Fri, 30 Mar 2018 02:28:04 -0400 Subject: [PATCH 2/2] CodeBlock::getFunctionArgs used the wrong offsets --- Engine/source/console/codeBlock.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Engine/source/console/codeBlock.cpp b/Engine/source/console/codeBlock.cpp index f8f814f5b..6b60e7789 100644 --- a/Engine/source/console/codeBlock.cpp +++ b/Engine/source/console/codeBlock.cpp @@ -698,10 +698,10 @@ String CodeBlock::getFunctionArgs(U32 ip) { StringBuilder str; - U32 fnArgc = code[ip + 5]; + U32 fnArgc = code[ip + 8]; for (U32 i = 0; i < fnArgc; ++i) { - StringTableEntry var = CodeToSTE(code, ip + (i * 2) + 6); + StringTableEntry var = CodeToSTE(code, ip + (i * 2) + 9); if (i != 0) str.append(", ");