As suggested, extract strlen calls from sizes into variables so it isn't called twice

This commit is contained in:
Glenn Smith 2018-03-08 20:59:40 -05:00
parent ed10ce2511
commit 6b024b21bf
33 changed files with 171 additions and 114 deletions

View file

@ -1575,8 +1575,9 @@ const char* DInputDevice::getJoystickAxesString()
}
}
char* returnString = Con::getReturnBuffer( dStrlen( buf ) + 1 );
dStrcpy( returnString, buf, dStrlen(buf) + 1 );
dsize_t returnLen = dStrlen(buf) + 1;
char* returnString = Con::getReturnBuffer(returnLen);
dStrcpy( returnString, buf, returnLen );
return( returnString );
}

View file

@ -83,8 +83,9 @@ void installRedBookDevices()
if(::GetDriveTypeA(str) == DRIVE_CDROM)
{
Win32RedBookDevice * device = new Win32RedBookDevice;
device->mDeviceName = new char[dStrlen(str) + 1];
dStrcpy(device->mDeviceName, str, dStrlen(str) + 1);
dsize_t deviceNameLen = dStrlen(str) + 1;
device->mDeviceName = new char[deviceNameLen];
dStrcpy(device->mDeviceName, str, deviceNameLen);
RedBook::installDevice(device);
}