From 68b12981ae19486b23b98df351e4258d77d702d9 Mon Sep 17 00:00:00 2001 From: bank Date: Thu, 1 May 2014 13:11:21 +0400 Subject: [PATCH] Fix: dSprintf should receive size of the buffer, not the size of the pointer. It was safe, as we are using static console return buffer, which is large enough to hold enough data (default is 2048). --- Engine/source/T3D/missionArea.cpp | 2 +- Engine/source/gui/editor/guiDebugger.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Engine/source/T3D/missionArea.cpp b/Engine/source/T3D/missionArea.cpp index d11aa91ce..1e592b7b2 100644 --- a/Engine/source/T3D/missionArea.cpp +++ b/Engine/source/T3D/missionArea.cpp @@ -179,7 +179,7 @@ DefineEngineMethod( MissionArea, getArea, const char *, (),, char* returnBuffer = Con::getReturnBuffer(48); RectI area = object->getArea(); - dSprintf(returnBuffer, sizeof(returnBuffer), "%d %d %d %d", area.point.x, area.point.y, area.extent.x, area.extent.y); + dSprintf(returnBuffer, 48, "%d %d %d %d", area.point.x, area.point.y, area.extent.x, area.extent.y); return(returnBuffer); } diff --git a/Engine/source/gui/editor/guiDebugger.cpp b/Engine/source/gui/editor/guiDebugger.cpp index 625704bee..dbebc4e83 100644 --- a/Engine/source/gui/editor/guiDebugger.cpp +++ b/Engine/source/gui/editor/guiDebugger.cpp @@ -79,7 +79,7 @@ ConsoleMethod(DbgFileView, getCurrentLine, const char *, 2, 2, "()" S32 lineNum; const char *file = object->getCurrentLine(lineNum); char* ret = Con::getReturnBuffer(256); - dSprintf(ret, sizeof(ret), "%s\t%d", file, lineNum); + dSprintf(ret, 256, "%s\t%d", file, lineNum); return ret; }