From 59bf75c8f001405863e454bd355ad2705b0cb6c3 Mon Sep 17 00:00:00 2001 From: AzaezelX Date: Sun, 7 Jul 2019 22:52:23 -0500 Subject: [PATCH] logic cleanup. discount doubleups on normal generation if we've already got one calculated on out. --- .../shaderGen/HLSL/shaderFeatureHLSL.cpp | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/Engine/source/shaderGen/HLSL/shaderFeatureHLSL.cpp b/Engine/source/shaderGen/HLSL/shaderFeatureHLSL.cpp index 366f9117d..9056a4afc 100644 --- a/Engine/source/shaderGen/HLSL/shaderFeatureHLSL.cpp +++ b/Engine/source/shaderGen/HLSL/shaderFeatureHLSL.cpp @@ -858,16 +858,15 @@ Var* ShaderFeatureHLSL::getSurface(Vector& componentList, Mult { normal = new Var("normal", "float3"); meta->addStatement(new GenOp(" @;\r\n\n", new DecOp(normal))); - - } - if (!fd.features[MFT_NormalMap]) - { - Var* worldToTangent = getInWorldToTangent(componentList); - meta->addStatement(new GenOp(" @ = normalize(mul(@,float3(0,0,1.0f)));\r\n\n", normal, worldToTangent)); - } - else - { - meta->addStatement(new GenOp(" @ = normalize( half3( @ ) );\r\n", normal, wsNormal)); + if (!fd.features[MFT_NormalMap]) + { + Var* worldToTangent = getInWorldToTangent(componentList); + meta->addStatement(new GenOp(" @ = normalize(mul(@,float3(0,0,1.0f)));\r\n\n", normal, worldToTangent)); + } + else + { + meta->addStatement(new GenOp(" @ = normalize( half3( @ ) );\r\n", normal, wsNormal)); + } } Var* wsEyePos = (Var*)LangElement::find("eyePosWorld");