TorqueGameEngines/Torque3D
1
0
Fork 0
mirror of https://github.com/TorqueGameEngines/Torque3D.git synced 2026-02-13 03:33:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Issue found with PVS-Studio:

Browse source 
Many instances where we would create a object via a new call, and then check that it was non-null.

This is redundant, as if we ever were in a situation where new failed, we'd be crashing left and right already, so the additional check is wasted processing.
This commit is contained in:
Areloch 2015-07-21 23:22:21 -05:00
parent db532c0e1a
commit 527c3790d6
15 changed files with 164 additions and 262 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Engine/source/navigation/recastPolyList.cpp
View file

@ -72,8 +72,7 @@ U32 RecastPolyList::addPoint(const Point3F &p)
else vertcap *= 2;
// Allocate new vertex storage.
F32 *newverts = new F32[vertcap*3];
if(!newverts)
return 0;
dMemcpy(newverts, verts, nverts*3 * sizeof(F32));
dFree(verts);
verts = newverts;
@ -106,8 +105,7 @@ void RecastPolyList::begin(BaseMatInstance *material, U32 surfaceKey)
else tricap *= 2;
// Allocate new vertex storage.
S32 *newtris = new S32[tricap*3];
if(!newtris)
return;
dMemcpy(newtris, tris, ntris*3 * sizeof(S32));
dFree(tris);
tris = newtris;