TorqueGameEngines/Torque3D
1
0
Fork 0
mirror of https://github.com/TorqueGameEngines/Torque3D.git synced 2026-01-19 20:24:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix callonchildren varargs

Browse source 
std::move eats the sent variable, so store off a temp when applying it multiple times
This commit is contained in:
AzaezelX 2025-01-06 15:55:53 -06:00
parent 8274bbbca4
commit 385974ab55
1 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
Engine/source/console/simSet.cpp
View file

@ -231,26 +231,27 @@ void SimSet::scriptSort( const String &scriptCallbackFn )
void SimSet::callOnChildren( const String &method, S32 argc, ConsoleValue argv[], bool executeOnChildGroups )
{
// Prep the arguments for the console exec...
// Make sure and leave args[1] empty.
ConsoleValue args[21] = { };
args[0].setString(method.c_str());
for (S32 i = 0; i < argc; i++)
args[i + 2].setString(argv[i].getString());
S32 targc = argc;
for( iterator i = begin(); i != end(); i++ )
{
SimObject *childObj = static_cast<SimObject*>(*i);
// Prep the arguments for the console exec...
// // Make sure and leave args[1] empty.
ConsoleValue args[21] = { };
args[0].setString(method.c_str());
for (S32 arg = 0; arg < targc; arg++)
args[arg + 2].setString(argv[arg].getString());
if( childObj->isMethod( method.c_str() ) )
Con::execute(childObj, argc + 2, args);
Con::execute(childObj, targc + 2, args);
if( executeOnChildGroups )
{
SimSet* childSet = dynamic_cast<SimSet*>(*i);
if ( childSet )
childSet->callOnChildren( method, argc, argv, executeOnChildGroups );
childSet->callOnChildren( method, targc, argv, executeOnChildGroups );
}
}
}