crashfixes

IRangeValidatorScaled display was looking in the wrong var
afxMagicMissileData was misconverted and lacked a NULL initializer
This commit is contained in:
AzaezelX 2025-11-23 15:10:37 -06:00
parent 9ec752b646
commit 2b8d7855e4
2 changed files with 10 additions and 19 deletions

View file

@ -242,6 +242,7 @@ afxMagicMissileData::afxMagicMissileData()
caster_safety_time = U32_MAX; caster_safety_time = U32_MAX;
mProjectileShapeAsset.registerRefreshNotify(this); mProjectileShapeAsset.registerRefreshNotify(this);
projectileShape = NULL;
} }
afxMagicMissileData::afxMagicMissileData(const afxMagicMissileData& other, bool temp_clone) : GameBaseData(other, temp_clone) afxMagicMissileData::afxMagicMissileData(const afxMagicMissileData& other, bool temp_clone) : GameBaseData(other, temp_clone)
@ -531,26 +532,16 @@ bool afxMagicMissileData::preload(bool server, String &errorStr)
Con::errorf(ConsoleLogEntry::General, "afxMagicMissileData::preload: Invalid packet, bad datablockid(lightDesc): %d", lightDescId); Con::errorf(ConsoleLogEntry::General, "afxMagicMissileData::preload: Invalid packet, bad datablockid(lightDesc): %d", lightDescId);
} }
U32 assetStatus = ShapeAsset::getAssetErrCode(mProjectileShapeAsset); if (getProjectileShape())
if (assetStatus == AssetBase::Ok || assetStatus == AssetBase::UsingFallback)
{ {
projectileShape = getProjectileShape(); TSShapeInstance* pDummy = new TSShapeInstance(getProjectileShape(), !server);
if (bool(projectileShape) == false)
{
errorStr = String::ToString("afxMagicMissileData::preload: Couldn't load shape \"%s\"", _getProjectileShapeAssetId());
return false;
}
/* From stock Projectile code...
activateSeq = projectileShape->findSequence("activate");
maintainSeq = projectileShape->findSequence("maintain");
*/
}
if (bool(projectileShape)) // create an instance to preload shape data
{
TSShapeInstance* pDummy = new TSShapeInstance(projectileShape, !server);
delete pDummy; delete pDummy;
} }
else if (mProjectileShapeAsset.notNull())
{
errorStr = String::ToString("afxMagicMissileData::preload: Couldn't load shape \"%s\"", _getProjectileShapeAssetId());
return false;
}
return true; return true;
} }

View file

@ -1449,7 +1449,7 @@ GuiControl* GuiInspectorTypeRangedS32::constructEditControl()
if (scaledValidator) if (scaledValidator)
{ {
retCtrl->setField("range", String::ToString("%d %d", scaledValidator->getMin(), scaledValidator->getMax())); retCtrl->setField("range", String::ToString("%d %d", scaledValidator->getMin(), scaledValidator->getMax()));
if (validator->getFidelity() > 1) if (scaledValidator->getScaleFactor() > 1)
retCtrl->setField("increment", String::ToString("%d", scaledValidator->getScaleFactor())); retCtrl->setField("increment", String::ToString("%d", scaledValidator->getScaleFactor()));
} }
} }