add reload status to onNewDataBlock callback

and skip calling onremove/onadd if we're not reloading
This commit is contained in:
AzaezelX 2025-04-27 19:49:13 -05:00
parent 2852b33cec
commit 2ae10c7ce1
28 changed files with 35 additions and 37 deletions

View file

@ -345,7 +345,7 @@ bool Camera::onNewDataBlock( GameBaseData *dptr, bool reload )
if ( !mDataBlock || !Parent::onNewDataBlock( dptr, reload ) )
return false;
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}

View file

@ -601,7 +601,7 @@ bool Debris::onNewDataBlock( GameBaseData *dptr, bool reload )
if (mDataBlock->isTempClone())
return true;
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}

View file

@ -1127,7 +1127,7 @@ bool Explosion::onNewDataBlock( GameBaseData *dptr, bool reload )
if (mDataBlock->isTempClone())
return true;
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}

View file

@ -474,7 +474,7 @@ bool Lightning::onNewDataBlock( GameBaseData *dptr, bool reload )
if ( !mDataBlock || !Parent::onNewDataBlock( dptr, reload ) )
return false;
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}

View file

@ -1131,7 +1131,7 @@ bool ParticleEmitter::onNewDataBlock( GameBaseData *dptr, bool reload )
return true;
}
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}

View file

@ -254,7 +254,7 @@ bool ParticleEmitterNode::onNewDataBlock( GameBaseData *dptr, bool reload )
return false;
// Todo: Uncomment if this is a "leaf" class
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}

View file

@ -614,7 +614,7 @@ bool Precipitation::onNewDataBlock( GameBaseData *dptr, bool reload )
initMaterials();
}
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}

View file

@ -159,7 +159,7 @@ bool RibbonNode::onNewDataBlock( GameBaseData *dptr, bool reload )
return false;
// Todo: Uncomment if this is a "leaf" class
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}

View file

@ -451,7 +451,7 @@ bool Splash::onNewDataBlock( GameBaseData *dptr, bool reload )
if (!mDataBlock || !Parent::onNewDataBlock(dptr, reload))
return false;
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}

View file

@ -95,7 +95,7 @@ IMPLEMENT_CALLBACK( GameBaseData, onAdd, void, ( GameBase* obj ), ( obj ),
"}\n\n"
"@endtsexample\n" );
IMPLEMENT_CALLBACK( GameBaseData, onNewDataBlock, void, ( GameBase* obj ), ( obj ),
IMPLEMENT_CALLBACK( GameBaseData, onNewDataBlock, void, ( GameBase* obj, bool reload), ( obj, reload),
"@brief Called when the object has a new datablock assigned.\n\n"
"@param obj the GameBase object\n\n"
"@see onAdd for an example\n" );
@ -512,12 +512,12 @@ void GameBase::scriptOnAdd()
mDataBlock->onAdd_callback( this );
}
void GameBase::scriptOnNewDataBlock()
void GameBase::scriptOnNewDataBlock(bool reload)
{
// Script onNewDataBlock() must be called by the leaf class
// after everything is loaded.
if (mDataBlock && !isGhost())
mDataBlock->onNewDataBlock_callback( this );
mDataBlock->onNewDataBlock_callback( this, reload);
}
void GameBase::scriptOnRemove()

View file

@ -115,7 +115,7 @@ public:
/// @{
DECLARE_CALLBACK( void, onAdd, ( GameBase* obj ) );
DECLARE_CALLBACK( void, onRemove, ( GameBase* obj ) );
DECLARE_CALLBACK( void, onNewDataBlock, ( GameBase* obj ) );
DECLARE_CALLBACK( void, onNewDataBlock, ( GameBase* obj, bool reload) );
DECLARE_CALLBACK( void, onMount, ( SceneObject* obj, SceneObject* mountObj, S32 node ) );
DECLARE_CALLBACK( void, onUnmount, ( SceneObject* obj, SceneObject* mountObj, S32 node ) );
/// @}
@ -299,7 +299,7 @@ public:
/// Executes the 'onNewDataBlock' script function for this object.
///
/// @note This must be called after everything is loaded.
void scriptOnNewDataBlock();
void scriptOnNewDataBlock(bool reload = false);
/// Executes the 'onRemove' script function for this object.
/// @note This must be called while the object is still valid

View file

@ -422,7 +422,7 @@ bool Item::onNewDataBlock( GameBaseData *dptr, bool reload )
return false;
if (!mSubclassItemHandlesScene)
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
if ( isProperlyAdded() )
_updatePhysics();

View file

@ -142,7 +142,7 @@ bool MissionMarker::onNewDataBlock( GameBaseData *dptr, bool reload )
mDataBlock = dynamic_cast<MissionMarkerData*>( dptr );
if ( !mDataBlock || !Parent::onNewDataBlock( dptr, reload ) )
return(false);
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return(true);
}

View file

@ -181,7 +181,7 @@ bool PathCamera::onNewDataBlock( GameBaseData *dptr, bool reload )
if ( !mDataBlock || !Parent::onNewDataBlock( dptr, reload ) )
return false;
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}

View file

@ -134,7 +134,7 @@ bool PathShape::onNewDataBlock(GameBaseData* dptr, bool reload)
if (!mDataBlock || !Parent::onNewDataBlock(dptr, reload))
return false;
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}

View file

@ -1923,7 +1923,7 @@ bool Player::onNewDataBlock( GameBaseData *dptr, bool reload )
onScaleChanged();
resetWorldBox();
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}

View file

@ -350,7 +350,7 @@ bool ProximityMine::onNewDataBlock( GameBaseData* dptr, bool reload )
if ( !mDataBlock || !Parent::onNewDataBlock( dptr, reload ) )
return false;
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}

View file

@ -906,7 +906,7 @@ bool RigidShape::onNewDataBlock(GameBaseData* dptr, bool reload)
else
mRigid.setObjectInertia(mObjBox.maxExtents - mObjBox.minExtents);
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}

View file

@ -219,7 +219,7 @@ bool StaticShape::onNewDataBlock(GameBaseData* dptr, bool reload)
if (!mDataBlock || !Parent::onNewDataBlock(dptr, reload))
return false;
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}

View file

@ -465,7 +465,7 @@ bool Trigger::onNewDataBlock( GameBaseData *dptr, bool reload )
if ( !mDataBlock || !Parent::onNewDataBlock( dptr, reload ) )
return false;
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}

View file

@ -545,7 +545,7 @@ bool AITurretShape::onNewDataBlock(GameBaseData* dptr, bool reload)
mShapeInstance->setTimeScale(mStateAnimThread,0);
}
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}

View file

@ -440,7 +440,7 @@ bool TurretShape::onNewDataBlock(GameBaseData* dptr, bool reload)
if (!mSubclassTurretShapeHandlesScene)
{
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
}
return true;

View file

@ -407,7 +407,7 @@ bool FlyingVehicle::onNewDataBlock(GameBaseData* dptr, bool reload)
mJetThread[i] = 0;
}
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}

View file

@ -549,7 +549,7 @@ bool HoverVehicle::onNewDataBlock(GameBaseData* dptr, bool reload)
}
// Todo: Uncomment if this is a "leaf" class
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}

View file

@ -711,7 +711,7 @@ bool WheeledVehicle::onNewDataBlock(GameBaseData* dptr, bool reload)
mJetSound = SFX->createSource( mDataBlock->getWheeledVehicleSoundsProfile(WheeledVehicleData::JetSound), &getTransform() );
}
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}

View file

@ -206,7 +206,7 @@ bool afxSpellBook::onNewDataBlock(GameBaseData* dptr, bool reload)
if (!mDataBlock || !Parent::onNewDataBlock(dptr, reload))
return false;
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}

View file

@ -1064,7 +1064,7 @@ bool afxParticleEmitter::onNewDataBlock(GameBaseData* dptr, bool reload)
if (mDataBlock->isTempClone())
return true;
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}
@ -1108,7 +1108,7 @@ bool afxParticleEmitterVector::onNewDataBlock(GameBaseData* dptr, bool reload)
if (mDataBlock->isTempClone())
return true;
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}
@ -1177,7 +1177,7 @@ bool afxParticleEmitterCone::onNewDataBlock(GameBaseData* dptr, bool reload)
if (mDataBlock->isTempClone())
return true;
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}
@ -1294,7 +1294,7 @@ bool afxParticleEmitterPath::onNewDataBlock(GameBaseData* dptr, bool reload)
if (mDataBlock->isTempClone())
return true;
scriptOnNewDataBlock();
scriptOnNewDataBlock(reload);
return true;
}

View file

@ -78,17 +78,15 @@ function spawnGameObject(%name, %addToScene)
return 0;
}
function GameBaseData::onNewDataBlock(%this, %obj)
function GameBaseData::onNewDataBlock(%this, %obj, %reload)
{
if (%obj.firstDataCheck)
if (%reload)
{
if(%this.isMethod("onRemove"))
%this.onRemove(%obj);
if(%this.isMethod("onAdd"))
%this.onAdd(%obj);
}
else
%obj.firstDataCheck = true;
}
function saveGameObject(%name, %tamlPath, %scriptPath)