From 113b3324a85ab5f6944fb2e50182d07030af70d7 Mon Sep 17 00:00:00 2001 From: AzaezelX Date: Mon, 27 Nov 2023 19:45:15 -0600 Subject: [PATCH] filter out component inspector button callbacks specifically targets the undo manager via avoiding onInspectorFieldModified et al tripping on clicks --- Engine/source/gui/editor/inspector/dynamicField.cpp | 2 +- Engine/source/gui/editor/inspector/field.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Engine/source/gui/editor/inspector/dynamicField.cpp b/Engine/source/gui/editor/inspector/dynamicField.cpp index cebaa890a..477768c5a 100644 --- a/Engine/source/gui/editor/inspector/dynamicField.cpp +++ b/Engine/source/gui/editor/inspector/dynamicField.cpp @@ -74,7 +74,7 @@ void GuiInspectorDynamicField::setData( const char* data, bool callbacks ) { target->inspectPreApply(); - if( callbacks ) + if( callbacks && !mField->flag.test(AbstractClassRep::FieldFlags::FIELD_ComponentInspectors)) { if( isRemoval ) Con::executef( mInspector, "onFieldRemoved", target->getIdString(), mDynField->slotName ); diff --git a/Engine/source/gui/editor/inspector/field.cpp b/Engine/source/gui/editor/inspector/field.cpp index 34fe76c80..35f85f405 100644 --- a/Engine/source/gui/editor/inspector/field.cpp +++ b/Engine/source/gui/editor/inspector/field.cpp @@ -378,7 +378,7 @@ void GuiInspectorField::setData( const char* data, bool callbacks ) // Fire callback single-object undo. - if( callbacks ) + if( callbacks && !mField->flag.test(AbstractClassRep::FieldFlags::FIELD_ComponentInspectors) ) Con::executef( mInspector, "onInspectorFieldModified", target->getIdString(), mField->pFieldname,