TorqueGameEngines/Torque3D
1
0
Fork 0
mirror of https://github.com/TorqueGameEngines/Torque3D.git synced 2026-02-24 00:53:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Issue found with PVS-Studio:

Browse source 
A lot of instances where some function args are not actually modified in any way, meaning that it is better for performance to convert them into const references. This prevents an additional copy, which can help performance.
This commit is contained in:
Areloch 2015-07-16 22:02:18 -05:00
parent ec63398042
commit 11398bb04e
40 changed files with 59 additions and 59 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Engine/source/util/triBoxCheck.h
View file

@ -38,7 +38,7 @@ bool triBoxOverlap(const Point3F &boxcenter, const Point3F &boxhalfsize, const P
/// Massage stuff into right format for triBoxOverlap test. This is really
/// just a helper function - use the other version if you want to be fast!
inline bool triBoxOverlap(Box3F box, Point3F a, Point3F b, Point3F c)
inline bool triBoxOverlap(Box3F box, const Point3F& a, const Point3F& b, const Point3F& c)
{
Point3F halfSize(box.len_x() / 2.f, box.len_y() / 2.f, box.len_z() / 2.f);

4
Engine/source/util/triRayCheck.cpp
View file

@ -125,8 +125,8 @@ bool intersect_triangle(Point3F orig, Point3F dir,
}
//*** Taken from TSE, and based on the above
bool castRayTriangle(Point3F orig, Point3F dir,
Point3F vert0, Point3F vert1, Point3F vert2,
bool castRayTriangle(const Point3F& orig, const Point3F& dir,
const Point3F& vert0, const Point3F& vert1, const Point3F& vert2,
F32 &t, Point2F &bary)
{
Point3F tvec, qvec;

2
Engine/source/util/triRayCheck.h
View file

@ -38,7 +38,7 @@ bool intersect_triangle(Point3F orig, Point3F dir,
F32& t, F32& u, F32& v);
//*** Taken from TSE, but based on the above
bool castRayTriangle(Point3F orig, Point3F dir, Point3F vert0, Point3F vert1, Point3F vert2, F32 &t, Point2F &bary);
bool castRayTriangle(const Point3F& orig, const Point3F& dir, const Point3F& vert0, const Point3F& vert1, const Point3F& vert2, F32 &t, Point2F &bary);
bool castRayTriangle(const Point3D &orig, const Point3D &dir, const Point3D &vert0, const Point3D &vert1, const Point3D &vert2);
#endif // _TRIRAYCHECK_H_