mirror of
https://github.com/psforever/PSF-LoginServer.git
synced 2026-03-15 02:10:40 +00:00
407429ee21
The game uses a UDP-based protocol. Unlike TCP, UDP does not guarantee that packets arrive, or that they arrive in the correct order. For this reason, the game protocol implements those features using the following: * All packets have a sequence number that is utilized for reordering * Important packets are wrapped in a SlottedMetaPacket with a subslot number * RelatedA packets ae used to request lost packets using the subslot number * RelatedB packets are used to confirm received SlottedMetaPackets All of these go both ways, server <-> client. We used to only partially implement these features: Outgoing packet bundles used SMPs and could be resent, but not all packets were bundled and there was no logic for requesting lost packets from the client and there was no packet reordering, which resulted in dire consequences in the case of packet loss (zoning failures, crashes and many other odd bugs). This patch addresses all of these issues. * Packet bundling: Packets are now automatically bundled and sent as SlottedMetaPackets using a recurring timer. All manual bundling functionality was removed. * Packet reordering: Incoming packets, if received out of order, are stashed and reordered. The maximum wait time for reordering is 20ms. * Packet requesting: Missing SlottedMetaPackets are requested from the client. * PacketCoding refactor: Dropped confusing packet container types. Fixes #5. * Crypto rewrite: PSCrypto is based on a ancient buggy version of cryptopp. Updating to a current version was not possible because it removed the MD5-MAC algorithm. For more details, see Md5Mac.scala. This patch replaces PSCrypto with native Scala code. * Added two new actors: * SocketActor: A simple typed UDP socket actor * MiddlewareActor: The old session pipeline greatly simplified into a typed actor that does most of the things mentioned above. * Begun work on a headless client * Fixed anniversary gun breaking stamina regen * Resolved a few sentry errors
50 lines
1.2 KiB
Scala
50 lines
1.2 KiB
Scala
// Copyright (c) 2017 PSForever
|
|
package game
|
|
|
|
import org.specs2.mutable._
|
|
import net.psforever.packet._
|
|
import net.psforever.packet.game._
|
|
import net.psforever.types.Vector3
|
|
import scodec.bits._
|
|
|
|
class BugReportMessageTest extends Specification {
|
|
val string =
|
|
hex"89 03000000 0F000000 8B4465632020322032303039 1 1 0 19 6C511 656B1 7A11 830610062006300 843100320033003400"
|
|
|
|
"decode" in {
|
|
PacketCoding.decodePacket(string).require match {
|
|
case BugReportMessage(major, minor, date, btype, repeat, unk, zone, loc, summary, desc) =>
|
|
major mustEqual 3
|
|
minor mustEqual 15
|
|
date mustEqual "Dec 2 2009"
|
|
btype mustEqual BugType.GAMEPLAY
|
|
repeat mustEqual true
|
|
zone mustEqual 25
|
|
loc.x mustEqual 674.84375f
|
|
loc.y mustEqual 726.78906f
|
|
loc.z mustEqual 69.90625f
|
|
summary mustEqual "abc"
|
|
desc mustEqual "1234"
|
|
case _ =>
|
|
ko
|
|
}
|
|
}
|
|
|
|
"encode" in {
|
|
val msg = BugReportMessage(
|
|
3,
|
|
15,
|
|
"Dec 2 2009",
|
|
BugType.GAMEPLAY,
|
|
true,
|
|
0,
|
|
25,
|
|
Vector3(674.84375f, 726.78906f, 69.90625f),
|
|
"abc",
|
|
"1234"
|
|
)
|
|
val pkt = PacketCoding.encodePacket(msg).require.toByteVector
|
|
|
|
pkt mustEqual string
|
|
}
|
|
}
|