making .max calls safer by checking .nonEmpty first (#1185)

This commit is contained in:
Fate-JH 2024-03-29 00:40:29 -04:00 committed by GitHub
parent 34e2ad5ea3
commit b7dc2b6623
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -93,7 +93,7 @@ class BlockMap(fullMapWidth: Int, fullMapHeight: Int, desiredSpanSize: Int) {
* @return a conglomerate sector which lists all of the entities in the discovered sector(s)
*/
def sector(indices: Iterable[Int], range: Float): SectorPopulation = {
if (indices.max < blocks.size) {
if (indices.nonEmpty && indices.max < blocks.size) {
BlockMap.quickToSectorGroup(range, BlockMap.sectorsOnlyWithinBlockStructure(indices, blocks) )
} else {
SectorGroup(Nil)
@ -527,7 +527,7 @@ object BlockMap {
list: Iterable[Int],
structure: Iterable[Sector]
): Iterable[Sector] = {
if (list.max < structure.size) {
if (list.nonEmpty && list.max < structure.size) {
val structureSeq = structure.toSeq
list.toSet.map { structureSeq }
} else {