Minor Squad Refactor (#740)

* disassembled SquadService's receive cases into separate methods

* making certain the correct sender reaches the correct functions

* regex

* getting rid of warnings

src/main/scala/net/psforever/actors/net/MiddlewareActor.scala

@@ -521,6 +521,10 @@ class MiddlewareActor(
       case packet: PlanetSideCryptoPacket =>
         log.error(s"Unexpected crypto packet '$packet'")
         Behaviors.same
+
+      case packet =>
+        log.error(s"Unexpected type of packet '$packet'")
+        Behaviors.same
     }
   }
 

src/main/scala/net/psforever/packet/PacketCoding.scala

@@ -106,7 +106,8 @@ object PacketCoding {
     packet.encode match {
       case Successful(payload) =>
         packet match {
-          case _: PlanetSideCryptoPacket => Successful(payload)
+          case _: PlanetSideCryptoPacket =>
+            Successful(payload)
           case packet: PlanetSideControlPacket =>
             ControlPacketOpcode.codec.encode(packet.opcode) match {
               case Successful(opcode) => Successful(hex"00".bits ++ opcode ++ payload)
@@ -117,6 +118,8 @@ object PacketCoding {
               case Successful(opcode) => Successful(opcode ++ payload)
               case f @ Failure(_)     => f
             }
+          case _ =>
+            Failure(Err("packet not supported"))
         }
       case f @ Failure(_) => f
     }