added and expanded tests in hopes of increasing code coverage score

added tests for AvatarService and PacketCodingActor; especially PCA tests
2026-03-17 19:10:37 +00:00 · 2017-12-05 00:37:24 -05:00 · 2017-12-05 00:37:24 -05:00 · 3aee0ab4e8
commit 3aee0ab4e8
parent 0e5afe6cfd
69 changed files with 4534 additions and 3037 deletions
--- a/common/src/test/scala/game/objectcreate/OneMannedFieldTurretDataTest.scala
+++ b/common/src/test/scala/game/objectcreate/OneMannedFieldTurretDataTest.scala
@ -0,0 +1,110 @@
+// Copyright (c) 2017 PSForever
+package game.objectcreate
+
+import net.psforever.packet.PacketCoding
+import net.psforever.packet.game.{ObjectCreateMessage, PlanetSideGUID}
+import net.psforever.packet.game.objectcreate._
+import net.psforever.types.PlanetSideEmpire
+import org.specs2.mutable._
+import scodec.bits._
+
+class OneMannedFieldTurretDataTest extends Specification {
+  val string_orion = hex"17 5E010000 D82640B 92F76 01D65 F611 00 00 5E 4400006304BFC1E4041826E1503900000010104CE704C06400000"
+
+  "OneMannedFieldTurretData" should {
+    "decode (orion)" in {
+      PacketCoding.DecodePacket(string_orion).require match {
+        case ObjectCreateMessage(len, cls, guid, parent, data) =>
+          len mustEqual 350
+          cls mustEqual ObjectClass.portable_manned_turret_vs
+          guid mustEqual PlanetSideGUID(2916)
+          parent.isDefined mustEqual false
+          data.isDefined mustEqual true
+          data.get.isInstanceOf[OneMannedFieldTurretData] mustEqual true
+          val omft = data.get.asInstanceOf[OneMannedFieldTurretData]
+          omft.deploy.pos.coord.x mustEqual 3567.1406f
+          omft.deploy.pos.coord.y mustEqual 2988.0078f
+          omft.deploy.pos.coord.z mustEqual 71.84375f
+          omft.deploy.pos.orient.x mustEqual 0f
+          omft.deploy.pos.orient.y mustEqual 0f
+          omft.deploy.pos.orient.z mustEqual 185.625f
+          omft.deploy.faction mustEqual PlanetSideEmpire.VS
+          omft.deploy.unk mustEqual 2
+          omft.deploy.player_guid mustEqual PlanetSideGUID(2502)
+          omft.health mustEqual 255
+          omft.internals.isDefined mustEqual true
+          val internals = omft.internals.get
+          internals.objectClass mustEqual ObjectClass.energy_gun_vs
+          internals.guid mustEqual PlanetSideGUID(2615)
+          internals.parentSlot mustEqual 1
+          internals.obj.isInstanceOf[WeaponData] mustEqual true
+          val wep = internals.obj.asInstanceOf[WeaponData]
+          wep.unk1 mustEqual 0x6
+          wep.unk2 mustEqual 0x8
+          wep.fire_mode mustEqual 0
+          val ammo = wep.ammo.head
+          ammo.objectClass mustEqual ObjectClass.energy_gun_ammo
+          ammo.guid mustEqual PlanetSideGUID(2510)
+          ammo.parentSlot mustEqual 0
+          ammo.obj.isInstanceOf[AmmoBoxData] mustEqual true
+          ammo.obj.asInstanceOf[AmmoBoxData].unk mustEqual 8
+        case _ =>
+          ko
+      }
+    }
+
+    "encode (orion)" in {
+      val obj = OneMannedFieldTurretData(
+        CommonFieldData(
+          PlacementData(3567.1406f, 2988.0078f, 71.84375f, 0f, 0f, 185.625f),
+          PlanetSideEmpire.VS, 2, PlanetSideGUID(2502)
+        ),
+        255,
+        OneMannedFieldTurretData.orion(PlanetSideGUID(2615), 0x6, 0x8, PlanetSideGUID(2510), 8)
+      )
+      val msg = ObjectCreateMessage(ObjectClass.portable_manned_turret_vs, PlanetSideGUID(2916), obj)
+      val pkt = PacketCoding.EncodePacket(msg).require.toByteVector
+      val pkt_bitv = pkt.toBitVector
+      val ori_bitv = string_orion.toBitVector
+      pkt_bitv.take(189) mustEqual ori_bitv.take(189)
+      pkt_bitv.drop(200) mustEqual ori_bitv.drop(200)
+      //TODO work on OneMannedFieldTurretData to make this pass as a single stream
+    }
+
+    "avenger" in {
+      OneMannedFieldTurretData.avenger(PlanetSideGUID(1), 2, 3, PlanetSideGUID(4), 5) mustEqual
+        InternalSlot(ObjectClass.energy_gun_tr, PlanetSideGUID(1), 1,
+          WeaponData(2, 3, ObjectClass.energy_gun_ammo, PlanetSideGUID(4), 0,
+            AmmoBoxData(5)
+          )
+        )
+    }
+
+    "generic" in {
+      OneMannedFieldTurretData.generic(PlanetSideGUID(1), 2, 3, PlanetSideGUID(4), 5) mustEqual
+        InternalSlot(ObjectClass.energy_gun, PlanetSideGUID(1), 1,
+          WeaponData(2, 3, ObjectClass.energy_gun_ammo, PlanetSideGUID(4), 0,
+            AmmoBoxData(5)
+          )
+        )
+    }
+
+    "orion" in {
+      OneMannedFieldTurretData.orion(PlanetSideGUID(1), 2, 3, PlanetSideGUID(4), 5) mustEqual
+        InternalSlot(ObjectClass.energy_gun_vs, PlanetSideGUID(1), 1,
+          WeaponData(2, 3, ObjectClass.energy_gun_ammo, PlanetSideGUID(4), 0,
+            AmmoBoxData(5)
+          )
+        )
+    }
+
+    "osprey" in {
+      OneMannedFieldTurretData.osprey(PlanetSideGUID(1), 2, 3, PlanetSideGUID(4), 5) mustEqual
+        InternalSlot(ObjectClass.energy_gun_nc, PlanetSideGUID(1), 1,
+          WeaponData(2, 3, ObjectClass.energy_gun_ammo, PlanetSideGUID(4), 0,
+            AmmoBoxData(5)
+          )
+        )
+    }
+  }
+}